From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42444)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from
	<SRS0=qtPb=PY=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1akgrR-0001fL-Hd
	for qemu-devel@nongnu.org; Mon, 28 Mar 2016 19:46:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from
	<SRS0=qtPb=PY=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1akgrN-0006lZ-K6
	for qemu-devel@nongnu.org; Mon, 28 Mar 2016 19:46:17 -0400
Received: from sonata.ens-lyon.org ([140.77.166.138]:47133)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from
	<SRS0=qtPb=PY=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1akgrN-0006lN-DO
	for qemu-devel@nongnu.org; Mon, 28 Mar 2016 19:46:13 -0400
Date: Tue, 29 Mar 2016 01:46:12 +0200
From: Samuel Thibault <samuel.thibault@gnu.org>
Message-ID: <20160328234612.GB3694@var.home>
References: <1458862451-31703-1-git-send-email-samuel.thibault@ens-lyon.org>
	<1458862451-31703-3-git-send-email-samuel.thibault@ens-lyon.org>
	<56F949C4.3070302@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56F949C4.3070302@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv4 2/2] slirp: Allow disabling IPv4 or IPv6
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: jasowang@redhat.com, jan.kiszka@siemens.com, thuth@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

Eric Blake, on Mon 28 Mar 2016 09:12:04 -0600, wrote:
> > +    if ((user->has_ipv6 && user->ipv6 && !user->has_ipv4)
> > +            || (user->has_ipv4 && !user->ipv4))
> > +        ipv4 = 0;
> 
> Inconsistent with current qemu style.  Should be:
> 
>     if ((user->has_ipv6 && user->ipv6 && !user->has_ipv4) ||
>         (user->has_ipv4 && !user->ipv4)) {

Ah, I didn't know about that one.  I personally prefer it the other way,
but alright.

> In particular, the missing {} (should) fail ./scripts/checkpatch.pl.

Right, sorry, it seems I forgot to re-run the script after the last
rework.

Samuel