From: Stefan Hajnoczi <stefanha@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [RFC 5/7] virtio: handle virtqueue_read_next_desc() errors
Date: Tue, 29 Mar 2016 12:14:51 +0100 [thread overview]
Message-ID: <20160329111451.GD19777@stefanha-x1.localdomain> (raw)
In-Reply-To: <20160325070100.GG20431@ad.usersys.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
On Fri, Mar 25, 2016 at 03:01:00PM +0800, Fam Zheng wrote:
> On Thu, 03/24 17:56, Stefan Hajnoczi wrote:
> > @@ -389,7 +395,7 @@ void virtqueue_get_avail_bytes(VirtQueue *vq, unsigned int *in_bytes,
> > unsigned int max, num_bufs, indirect = 0;
> > VRingDesc desc;
> > hwaddr desc_pa;
> > - int i;
> > + unsigned int i;
>
> This change seems a candicate for a separate patch, otherwise looks good to me!
Will fix in the next revision.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-03-29 11:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 17:56 [Qemu-devel] [RFC 0/7] virtio: avoid exit() when device enters invalid states Stefan Hajnoczi
2016-03-24 17:56 ` [Qemu-devel] [RFC 1/7] virtio: fix stray tab character Stefan Hajnoczi
2016-03-25 6:45 ` Fam Zheng
2016-03-24 17:56 ` [Qemu-devel] [RFC 2/7] virtio: stop virtqueue processing if device is broken Stefan Hajnoczi
2016-03-25 6:48 ` Fam Zheng
2016-03-29 11:12 ` Stefan Hajnoczi
2016-03-29 7:52 ` Cornelia Huck
2016-03-29 11:14 ` Stefan Hajnoczi
2016-03-24 17:56 ` [Qemu-devel] [RFC 3/7] virtio: handle virtqueue_map_desc() errors Stefan Hajnoczi
2016-03-24 17:56 ` [Qemu-devel] [RFC 4/7] virtio: handle virtqueue_get_avail_bytes() errors Stefan Hajnoczi
2016-03-24 17:56 ` [Qemu-devel] [RFC 5/7] virtio: handle virtqueue_read_next_desc() errors Stefan Hajnoczi
2016-03-25 7:01 ` Fam Zheng
2016-03-29 11:14 ` Stefan Hajnoczi [this message]
2016-03-24 17:56 ` [Qemu-devel] [RFC 6/7] virtio: handle virtqueue_num_heads() errors Stefan Hajnoczi
2016-03-25 7:03 ` Fam Zheng
2016-03-24 17:56 ` [Qemu-devel] [RFC 7/7] virtio: handle virtqueue_get_head() errors Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329111451.GD19777@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=famz@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).