From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akuJG-0005d6-U4 for qemu-devel@nongnu.org; Tue, 29 Mar 2016 10:07:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akuJB-00018D-66 for qemu-devel@nongnu.org; Tue, 29 Mar 2016 10:07:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akuJB-000186-0b for qemu-devel@nongnu.org; Tue, 29 Mar 2016 10:07:49 -0400 Date: Tue, 29 Mar 2016 17:07:44 +0300 From: "Michael S. Tsirkin" Message-ID: <20160329170427-mutt-send-email-mst@redhat.com> References: <1459260049-18231-1-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459260049-18231-1-git-send-email-den@openvz.org> Subject: Re: [Qemu-devel] [PATCH 1/1] virtio-balloon: reset the statistic timer to load device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Pavel Butsykin , qemu-devel@nongnu.org, rkagan@virtuozzo.com On Tue, Mar 29, 2016 at 05:00:49PM +0300, Denis V. Lunev wrote: > From: Pavel Butsykin > > If before loading snapshot we had set the timer of statistics, then after > applying snapshot the expiry time would be irrelevant for the restored > state of the virtual clocks. A simple fix is just to restart the timer > after loading snapshot. > > For the user it may look like a long delay of statistics update after switch > to the snapshot. > > Signed-off-by: Pavel Butsykin > Reviewed-by: Roman Kagan > Signed-off-by: Denis V. Lunev > CC: Michael S. Tsirkin I'm inclined to think we really should migrate the timer, otherwise user might wait twice as long as expected ... > --- > hw/virtio/virtio-balloon.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c > index 22ad25c..c74101e 100644 > --- a/hw/virtio/virtio-balloon.c > +++ b/hw/virtio/virtio-balloon.c > @@ -426,6 +426,10 @@ static int virtio_balloon_load_device(VirtIODevice *vdev, QEMUFile *f, > > s->num_pages = qemu_get_be32(f); > s->actual = qemu_get_be32(f); > + > + if (balloon_stats_enabled(s)) { > + balloon_stats_change_timer(s, s->stats_poll_interval); > + } > return 0; > } > > -- > 2.1.4