From: Samuel Thibault <samuel.thibault@gnu.org>
To: Thomas Huth <thuth@redhat.com>
Cc: jan.kiszka@siemens.com, jasowang@redhat.com,
qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6
Date: Wed, 30 Mar 2016 17:04:09 +0200 [thread overview]
Message-ID: <20160330150409.GC15708@var.bordeaux.inria.fr> (raw)
In-Reply-To: <56FB9096.9070102@redhat.com>
Hello,
Thomas Huth, on Wed 30 Mar 2016 10:38:46 +0200, wrote:
> > - "-netdev user,id=str[,net=addr[/mask]][,host=addr][,ipv6-net=addr[/int]]\n"
> > - " [,ipv6-host=addr][,restrict=on|off][,hostname=host][,dhcpstart=addr]\n"
> > + "-netdev user,id=str[,ipv4][,net=addr[/mask]][,host=addr]\n"
> > + " [,ipv6][,ipv6-net=addr[/int]][,ipv6-host=addr]\n"
> > + " [,restrict=on|off][,hostname=host][,dhcpstart=addr]\n"
> > " [,dns=addr][,ipv6-dns=addr][,dnssearch=domain][,tftp=dir]\n"
> > " [,bootfile=f][,hostfwd=rule][,guestfwd=rule]"
>
> Shouldn't that rather be "[,ipv4=on|off]" and "[,ipv6=on|off]" for a
> boolean value?
Well, just like the rest of these ipv4/ipv6 options, they do accept
=on|off, but it's not documented in the qemu-options.hx file. Should we
fix them all?
Samuel
next prev parent reply other threads:[~2016-03-30 15:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 23:44 [Qemu-devel] [PATCH 0/5] ipv4-only and ipv6-only support Samuel Thibault
2016-03-28 23:44 ` [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6 Samuel Thibault
2016-03-30 8:38 ` Thomas Huth
2016-03-30 15:04 ` Samuel Thibault [this message]
2016-03-30 15:06 ` Thomas Huth
2016-03-30 15:13 ` Samuel Thibault
2016-03-30 15:29 ` Thomas Huth
2016-03-30 15:36 ` Samuel Thibault
2016-03-30 15:54 ` Eric Blake
2016-03-28 23:44 ` [Qemu-devel] [PATCH 2/5] slirp: Split get_dns_addr Samuel Thibault
2016-03-30 8:57 ` Thomas Huth
2016-03-28 23:44 ` [Qemu-devel] [PATCH 3/5] slirp: Add dns6 resolution Samuel Thibault
2016-03-30 9:32 ` Thomas Huth
2016-03-28 23:44 ` [Qemu-devel] [PATCH 4/5] slirp: Support link-local DNS addresses Samuel Thibault
2016-03-30 9:49 ` Thomas Huth
2016-03-28 23:44 ` [Qemu-devel] [PATCH 5/5] slirp: Add RDNSS advertisement Samuel Thibault
2016-03-30 9:55 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330150409.GC15708@var.bordeaux.inria.fr \
--to=samuel.thibault@gnu.org \
--cc=armbru@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).