From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54534)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1alHfL-00081z-Ju
	for qemu-devel@nongnu.org; Wed, 30 Mar 2016 11:04:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1alHfI-0006iT-ED
	for qemu-devel@nongnu.org; Wed, 30 Mar 2016 11:04:15 -0400
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:19286)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1alHfI-0006iN-71
	for qemu-devel@nongnu.org; Wed, 30 Mar 2016 11:04:12 -0400
Date: Wed, 30 Mar 2016 17:04:09 +0200
From: Samuel Thibault <samuel.thibault@gnu.org>
Message-ID: <20160330150409.GC15708@var.bordeaux.inria.fr>
References: <1459208679-27805-1-git-send-email-samuel.thibault@ens-lyon.org>
	<1459208679-27805-2-git-send-email-samuel.thibault@ens-lyon.org>
	<56FB9096.9070102@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56FB9096.9070102@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@redhat.com>
Cc: jan.kiszka@siemens.com, jasowang@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

Hello,

Thomas Huth, on Wed 30 Mar 2016 10:38:46 +0200, wrote:
> > -    "-netdev user,id=str[,net=addr[/mask]][,host=addr][,ipv6-net=addr[/int]]\n"
> > -    "         [,ipv6-host=addr][,restrict=on|off][,hostname=host][,dhcpstart=addr]\n"
> > +    "-netdev user,id=str[,ipv4][,net=addr[/mask]][,host=addr]\n"
> > +    "         [,ipv6][,ipv6-net=addr[/int]][,ipv6-host=addr]\n"
> > +    "         [,restrict=on|off][,hostname=host][,dhcpstart=addr]\n"
> >      "         [,dns=addr][,ipv6-dns=addr][,dnssearch=domain][,tftp=dir]\n"
> >      "         [,bootfile=f][,hostfwd=rule][,guestfwd=rule]"
> 
> Shouldn't that rather be "[,ipv4=on|off]" and "[,ipv6=on|off]" for a
> boolean value?

Well, just like the rest of these ipv4/ipv6 options, they do accept
=on|off, but it's not documented in the qemu-options.hx file.  Should we
fix them all?

Samuel