From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alG6P-0005Oq-K5 for qemu-devel@nongnu.org; Wed, 30 Mar 2016 09:24:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alG6M-0001MN-F6 for qemu-devel@nongnu.org; Wed, 30 Mar 2016 09:24:05 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:52807) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alG6M-0001Ld-3t for qemu-devel@nongnu.org; Wed, 30 Mar 2016 09:24:02 -0400 Received: from localhost by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 30 Mar 2016 14:23:59 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 144051B08067 for ; Wed, 30 Mar 2016 14:24:33 +0100 (BST) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u2UDNvr48192438 for ; Wed, 30 Mar 2016 13:23:57 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u2UDNvSK020844 for ; Wed, 30 Mar 2016 07:23:57 -0600 Date: Wed, 30 Mar 2016 15:23:55 +0200 From: Cornelia Huck Message-ID: <20160330152355.693aad1c.cornelia.huck@de.ibm.com> In-Reply-To: <1459342088-24311-2-git-send-email-pbonzini@redhat.com> References: <1459342088-24311-1-git-send-email-pbonzini@redhat.com> <1459342088-24311-2-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/9] virtio-dataplane: pass assign=true to virtio_queue_aio_set_host_notifier_handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: borntraeger@de.ibm.com, famz@redhat.com, qemu-devel@nongnu.org, mst@redhat.com On Wed, 30 Mar 2016 14:48:00 +0200 Paolo Bonzini wrote: > There is no need to run the handler one last time; the device is being > reset and it is okay to drop requests that are pending in the virtqueue. What about virtio_blk_save()? Could there be any pending requests in that case? > By omitting this call, we dodge a possible cause of races between the > dataplane thread on one side and the main/vCPU threads on the other. > > Signed-off-by: Paolo Bonzini > --- > hw/block/dataplane/virtio-blk.c | 2 +- > hw/scsi/virtio-scsi-dataplane.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-)