From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59186)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1alGOv-0004ex-7x
	for qemu-devel@nongnu.org; Wed, 30 Mar 2016 09:43:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1alGOq-0007MC-6s
	for qemu-devel@nongnu.org; Wed, 30 Mar 2016 09:43:13 -0400
Received: from e06smtp06.uk.ibm.com ([195.75.94.102]:44067)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1alGOp-0007M4-SV
	for qemu-devel@nongnu.org; Wed, 30 Mar 2016 09:43:08 -0400
Received: from localhost
	by e06smtp06.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <cornelia.huck@de.ibm.com>;
	Wed, 30 Mar 2016 14:43:07 +0100
Received: from b06cxnps3074.portsmouth.uk.ibm.com
	(d06relay09.portsmouth.uk.ibm.com [9.149.109.194])
	by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id DEB181B0804B
	for <qemu-devel@nongnu.org>; Wed, 30 Mar 2016 14:43:39 +0100 (BST)
Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com
	[9.149.37.251])
	by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id u2UDh4Aq4325848
	for <qemu-devel@nongnu.org>; Wed, 30 Mar 2016 13:43:04 GMT
Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id u2UCh6Zr013543
	for <qemu-devel@nongnu.org>; Wed, 30 Mar 2016 06:43:06 -0600
Date: Wed, 30 Mar 2016 15:43:02 +0200
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Message-ID: <20160330154302.506ea2a4.cornelia.huck@de.ibm.com>
In-Reply-To: <56FBD4DC.5070104@redhat.com>
References: <1459342088-24311-1-git-send-email-pbonzini@redhat.com>
	<1459342088-24311-2-git-send-email-pbonzini@redhat.com>
	<20160330152355.693aad1c.cornelia.huck@de.ibm.com>
	<56FBD4DC.5070104@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/9] virtio-dataplane: pass assign=true to
 virtio_queue_aio_set_host_notifier_handler
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: borntraeger@de.ibm.com, famz@redhat.com, qemu-devel@nongnu.org, mst@redhat.com

On Wed, 30 Mar 2016 15:30:04 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 30/03/2016 15:23, Cornelia Huck wrote:
> > > There is no need to run the handler one last time; the device is being
> > > reset and it is okay to drop requests that are pending in the virtqueue.
> > 
> > What about virtio_blk_save()? Could there be any pending requests in
> > that case?
> 
> Those would be processed when dataplane is restarted on the destination
> side, I think.  virtio_queue_set_host_notifier_fd_handler calls
> virtio_queue_host_notifier_read which connects the host notifier to the
> I/O thread and calls event_notifier_set to start processing it.

Makes sense; maybe mention that in the patch description as well?