From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alIRS-0001uJ-FA for qemu-devel@nongnu.org; Wed, 30 Mar 2016 11:53:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alIRR-0005ss-CR for qemu-devel@nongnu.org; Wed, 30 Mar 2016 11:53:58 -0400 Date: Wed, 30 Mar 2016 16:53:46 +0100 From: "Daniel P. Berrange" Message-ID: <20160330155340.GJ12311@redhat.com> References: <1459345997-1610-1-git-send-email-berrange@redhat.com> <1459345997-1610-3-git-send-email-berrange@redhat.com> <56FBF5F4.4020804@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <56FBF5F4.4020804@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 2/3] block: add support for encryption secrets in block I/O tests Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, qemu-block@nongnu.org On Wed, Mar 30, 2016 at 05:51:16PM +0200, Max Reitz wrote: > On 30.03.2016 15:53, Daniel P. Berrange wrote: > > The LUKS block driver tests will require the ability to specify > > encryption secrets with block devices. This requires using the > > --object argument to qemu-img/qemu-io to create a 'secret' > > object. > > > > When the IMGKEYSECRET env variable is set, it provides the > > password to be associated with a secret called 'keysec0' > > > > Signed-off-by: Daniel P. Berrange > > --- > > tests/qemu-iotests/common | 1 + > > tests/qemu-iotests/common.config | 6 ++++++ > > tests/qemu-iotests/common.filter | 3 ++- > > tests/qemu-iotests/common.rc | 16 +++++++++++++--- > > 4 files changed, 22 insertions(+), 4 deletions(-) > > Is there a reason why you didn't implement the same logic in > _qemu_img_wrapper as in _qemu_io_wrapper? Mostly because the --image-opts syntax isn't used with the 'create' command for qemu-img. I guess I could have trie to detect which command was being run and set the args accordingly. > This works, but it appears a bit overcomplicated to me. > > Reviewed-by: Max Reitz Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|