From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alHUO-00018m-VT for qemu-devel@nongnu.org; Wed, 30 Mar 2016 10:52:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alHUL-0003WP-PY for qemu-devel@nongnu.org; Wed, 30 Mar 2016 10:52:56 -0400 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:39249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alHUL-0003Vy-Fg for qemu-devel@nongnu.org; Wed, 30 Mar 2016 10:52:53 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 30 Mar 2016 15:52:51 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id DD64B1B0804B for ; Wed, 30 Mar 2016 15:53:24 +0100 (BST) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u2UEqnn45112180 for ; Wed, 30 Mar 2016 14:52:49 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u2UEqmq9012294 for ; Wed, 30 Mar 2016 08:52:49 -0600 Date: Wed, 30 Mar 2016 16:52:45 +0200 From: Cornelia Huck Message-ID: <20160330165245.345fb49f.cornelia.huck@de.ibm.com> In-Reply-To: <1459342088-24311-5-git-send-email-pbonzini@redhat.com> References: <1459342088-24311-1-git-send-email-pbonzini@redhat.com> <1459342088-24311-5-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/9] virtio-scsi: fix disabled mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: borntraeger@de.ibm.com, famz@redhat.com, qemu-devel@nongnu.org, mst@redhat.com On Wed, 30 Mar 2016 14:48:03 +0200 Paolo Bonzini wrote: > Add two missing checks for s->dataplane_fenced. In one case, QEMU > would skip injecting an IRQ due to a write to an uninitialized > EventNotifier's file descriptor. > > In the second case, the dataplane_disabled field was used by mistake; > in fact after fixing this occurrence it is completely unused. > > Signed-off-by: Paolo Bonzini > --- > hw/scsi/virtio-scsi.c | 4 ++-- > include/hw/virtio/virtio-scsi.h | 1 - > 2 files changed, 2 insertions(+), 3 deletions(-) It's a bit confusing that the disabled mode for virtio-scsi dataplane uses 'fenced' instead of 'disabled', but 'disabled' was already used... Reviewed-by: Cornelia Huck