From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40411)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1alYIy-0002q3-P6
	for qemu-devel@nongnu.org; Thu, 31 Mar 2016 04:50:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1alYIu-0004mD-Om
	for qemu-devel@nongnu.org; Thu, 31 Mar 2016 04:50:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43770)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1alYIu-0004m9-Jp
	for qemu-devel@nongnu.org; Thu, 31 Mar 2016 04:50:12 -0400
Date: Thu, 31 Mar 2016 09:50:07 +0100
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20160331085007.GC2265@work-vm>
References: <1459326950-17708-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<1459326950-17708-4-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<20160330114143.GA7580@work-vm> <56FC88D1.8080902@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56FC88D1.8080902@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH V2 3/3] colo-compare: introduce packet
	comparison thread
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Li Zhijian <lizhijian@cn.fujitsu.com>
Cc: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>, Gui jianfeng <guijianfeng@cn.fujitsu.com>, Jason Wang <jasowang@redhat.com>, "eddie.dong" <eddie.dong@intel.com>, qemu devel <qemu-devel@nongnu.org>, Yang Hongyang <hongyang.yang@easystack.cn>, zhanghailiang <zhang.zhanghailiang@huawei.com>

* Li Zhijian (lizhijian@cn.fujitsu.com) wrote:
> 
> 
> On 03/30/2016 07:41 PM, Dr. David Alan Gilbert wrote:
> [...]
> 
> >>>@@ -433,7 +532,9 @@ static void compare_pri_chr_in(void *opaque, const uint8_t *buf, int size)
> >>>      if (ret == 1) {
> >>>          if (packet_enqueue(s, PRIMARY_IN)) {
> >>>              error_report("primary: unsupported packet in");
> >>>-            compare_chr_send(s->chr_out, buf, size);
> >>>+            compare_chr_send(s->chr_out, s->pri_rs.buf, s->pri_rs.packet_len);
> >Doesn't that change belong in an earlier patch?
> >
> >>>+        } else {
> >>>+            qemu_event_set(&s->event);
> >Also these - why are these in this patch?
> This event is to wakeup comparison thread to do compare.
> Do you think we should put event related code to patch 2 ?

Ah OK; yes the event_set makes sense in this patch.

Dave

> Thanks
> Li
> >
> >>>          }
> 
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK