From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59629)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <olaf@aepfle.de>) id 1am18X-00016l-U0
	for qemu-devel@nongnu.org; Fri, 01 Apr 2016 11:37:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <olaf@aepfle.de>) id 1am18W-0000cL-VL
	for qemu-devel@nongnu.org; Fri, 01 Apr 2016 11:37:25 -0400
Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::9]:59923)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <olaf@aepfle.de>) id 1am18W-0000bY-Lo
	for qemu-devel@nongnu.org; Fri, 01 Apr 2016 11:37:24 -0400
Date: Fri, 1 Apr 2016 17:31:14 +0200
From: Olaf Hering <olaf@aepfle.de>
Message-ID: <20160401153114.GB22458@aepfle.de>
References: <1459512047-2344-1-git-send-email-olaf@aepfle.de>
	<CAFEAcA8YwgcgeymPtXU9QJP7DDj7ot1f+=oAoKhENvR1UVxFkA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAFEAcA8YwgcgeymPtXU9QJP7DDj7ot1f+=oAoKhENvR1UVxFkA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] build: link with libatomic on powerpc-linux
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

On Fri, Apr 01, Peter Maydell wrote:

> On 1 April 2016 at 13:00, Olaf Hering <olaf@aepfle.de> wrote:
> > Building on powerpc-linux fails with undefined reference to __atomic_load_8 in
> > icount_warp_rt(). Force linking to -latomic.
> 
> We should instead be fixing this by not doing atomic operations
> on types of larger than void*. This also causes problems on x86
> BSDs. I think there's already a proposed patch on the list for that.

Do you have a pointer to the proposed patch?
My change does not work for the --enable-linux-user case for some
reason.

Olaf