From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alzn3-0002tZ-Lv for qemu-devel@nongnu.org; Fri, 01 Apr 2016 10:11:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alzmz-0006FX-0o for qemu-devel@nongnu.org; Fri, 01 Apr 2016 10:11:09 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:44736) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alzmy-0006FK-MM for qemu-devel@nongnu.org; Fri, 01 Apr 2016 10:11:04 -0400 Received: from localhost by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 1 Apr 2016 15:11:03 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 70F7317D86CD for ; Fri, 1 Apr 2016 15:05:01 +0100 (BST) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u31E4MoP65208432 for ; Fri, 1 Apr 2016 14:04:22 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u31E4LYK023026 for ; Fri, 1 Apr 2016 08:04:22 -0600 Date: Fri, 1 Apr 2016 16:04:20 +0200 From: Cornelia Huck Message-ID: <20160401160420.469c49c7.cornelia.huck@de.ibm.com> In-Reply-To: <1459516794-23629-6-git-send-email-pbonzini@redhat.com> References: <1459516794-23629-1-git-send-email-pbonzini@redhat.com> <1459516794-23629-6-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/9] virtio: add aio handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: famz@redhat.com, borntraeger@de.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, tubo@linux.vnet.ibm.com, stefanha@redhat.com On Fri, 1 Apr 2016 15:19:50 +0200 Paolo Bonzini wrote: > From: "Michael S. Tsirkin" > > In addition to handling IO in vcpu thread and > in io thread, blk dataplane introduces yet another mode: > handling it by aio. > > This reuses the same handler as previous modes, > which triggers races as these were not designed to be reentrant. > > As a temporary fix, add a separate handler just for aio, this will make > it possible to disable regular handlers when dataplane is active. > > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Paolo Bonzini > --- > hw/virtio/virtio.c | 36 ++++++++++++++++++++++++++++++++---- > include/hw/virtio/virtio.h | 3 +++ > 2 files changed, 35 insertions(+), 4 deletions(-) Reviewed-by: Cornelia Huck