From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46841)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1am06C-0005Fg-Ic
	for qemu-devel@nongnu.org; Fri, 01 Apr 2016 10:31:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1am068-00020p-AK
	for qemu-devel@nongnu.org; Fri, 01 Apr 2016 10:30:56 -0400
Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:32835)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1am068-00020f-0Z
	for qemu-devel@nongnu.org; Fri, 01 Apr 2016 10:30:52 -0400
Received: from localhost
	by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <cornelia.huck@de.ibm.com>;
	Fri, 1 Apr 2016 15:30:49 +0100
Received: from b06cxnps4075.portsmouth.uk.ibm.com
	(d06relay12.portsmouth.uk.ibm.com [9.149.109.197])
	by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id EC7AA1B08061
	for <qemu-devel@nongnu.org>; Fri,  1 Apr 2016 15:31:22 +0100 (BST)
Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com
	[9.149.37.250])
	by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id u31EUklh5374268
	for <qemu-devel@nongnu.org>; Fri, 1 Apr 2016 14:30:46 GMT
Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id u31EUkdw008949
	for <qemu-devel@nongnu.org>; Fri, 1 Apr 2016 08:30:46 -0600
Date: Fri, 1 Apr 2016 16:30:44 +0200
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Message-ID: <20160401163044.1c91fcd5.cornelia.huck@de.ibm.com>
In-Reply-To: <56FE823E.9000201@de.ibm.com>
References: <1459516794-23629-1-git-send-email-pbonzini@redhat.com>
	<1459516794-23629-10-git-send-email-pbonzini@redhat.com>
	<56FE823E.9000201@de.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 9/9] virtio: remove starting/stopping checks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: famz@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, tubo@linux.vnet.ibm.com, stefanha@redhat.com, Paolo Bonzini <pbonzini@redhat.com>

On Fri, 1 Apr 2016 16:14:22 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> On 04/01/2016 03:19 PM, Paolo Bonzini wrote:
> > Reentrancy cannot happen while the BQL is being held.
> > 
> > Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> Reverting this patch makes the segfaults go away.
> 
> 
> 
> 
> 
> > ---
> >  hw/block/dataplane/virtio-blk.c | 12 ++----------
> >  hw/scsi/virtio-scsi-dataplane.c |  9 +--------
> >  include/hw/virtio/virtio-scsi.h |  2 --
> >  3 files changed, 3 insertions(+), 20 deletions(-)

:(

On the one hand, I'm wondering what we're missing here.

On the other hand, let's just skip the cleanup patches and get the bug
fixed?