From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-blk: assert on starting/stopping
Date: Mon, 4 Apr 2016 10:25:34 +0200 [thread overview]
Message-ID: <20160404102534.4ff786f2.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <5702239E.5070407@redhat.com>
On Mon, 4 Apr 2016 10:19:42 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 04/04/2016 10:10, Cornelia Huck wrote:
> > > This will be fixed by Cornelia's rework, and is an example of why I
> > > think patch 1/9 is a good idea (IOW, assign=false is harmful).
> >
> > So what do we want to do for 2.6? The aio handler rework (without the
> > cleanup) is needed. Do we want to include the minimal version of my
> > "keep handler assigned" patch (the one without the api rework) as well,
> > as it fixes a latent bug?
>
> I would, but Michael is more conservative in general. Since the
> difference between a bug and a feature is very fuzzy here, I would just
> omit my patch 9.
I'd omit patch 9 as well, but the knowledge that the "handler
deassigned" bug is still lurking makes me uncomfortable.
Would like to see a test from someone with a large setup, anyway (and I
need to enhance my test setup, I guess...)
next prev parent reply other threads:[~2016-04-04 8:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 10:37 [Qemu-devel] [PATCH] virtio-blk: assert on starting/stopping Michael S. Tsirkin
2016-04-03 19:59 ` Christian Borntraeger
2016-04-03 21:13 ` Paolo Bonzini
2016-04-04 8:10 ` Cornelia Huck
2016-04-04 8:19 ` Paolo Bonzini
2016-04-04 8:25 ` Cornelia Huck [this message]
2016-04-04 8:47 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160404102534.4ff786f2.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).