qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: forbid x-blockdev-del from acting on DriveInfo
Date: Mon, 4 Apr 2016 12:53:11 +0200	[thread overview]
Message-ID: <20160404105311.GB5651@noname.redhat.com> (raw)
In-Reply-To: <1459429663-1230-1-git-send-email-pbonzini@redhat.com>

Am 31.03.2016 um 15:07 hat Paolo Bonzini geschrieben:
> Failing on -drive/drive_add created BlockBackends was a
> requirement for x-blockdev-del, but it sneaked through
> the patch review.  Let's fix it now.
> 
> Example:
> 
> $ x86_64-softmmu/qemu-system-x86_64 -drive if=none,file=null-co://,id=null -qmp stdio
> >> {'execute':'qmp_capabilities'}
> << {"return": {}}
> >> {'execute':'x-blockdev-del','arguments':{'id':'null'}}
> << {"error": {"class": "GenericError", "desc": "Deleting block backend added with drive-add is not supported"}}
> 
> And without a DriveInfo:
> 
> >> { "execute": "blockdev-add", "arguments": { "options": { "driver":"null-co", "id":"null2"}}}
> << {"return": {}}
> >> {'execute':'x-blockdev-del','arguments':{'id':'null2'}}
> << {"return": {}}
> 
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Thanks, applied to the block branch.

Kevin

      reply	other threads:[~2016-04-04 10:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-31 13:07 [Qemu-devel] [PATCH] block: forbid x-blockdev-del from acting on DriveInfo Paolo Bonzini
2016-04-04 10:53 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160404105311.GB5651@noname.redhat.com \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).