qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Juan Quintela <quintela@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Amit Shah <amit.shah@redhat.com>,
	Marcel Apfelbaum <marcel@redhat.com>,
	John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Migration: Add i82801b11 migration data
Date: Mon, 4 Apr 2016 17:40:39 +0100	[thread overview]
Message-ID: <20160404164039.GB6629@work-vm> (raw)
In-Reply-To: <CAFEAcA96voBKB3VarfY9gb7OA4ZDyLgvFaim-gDgxDWv54ZhRQ@mail.gmail.com>

* Peter Maydell (peter.maydell@linaro.org) wrote:
> On 4 April 2016 at 17:14, Marcel Apfelbaum <marcel@redhat.com> wrote:
> > On 04/04/2016 06:54 PM, Dr. David Alan Gilbert (git) wrote:
> >>
> >> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >>
> >> The i82801b11 bridge didn't have a vmsd and thus didn't send
> >> any migration data, including that of its parent PCIBridge object.
> >> The symptom being if the guest used any devices behind the bridge
> >> the guest crashed (mostly with various interrupt related issues).
> >>
> >> Note: This will cause migration from old qemus that used this device to
> >> explicitly fail during migration as opposed to the guest crashing.
> 
> > If this patch was enough we got lucky :)
> > Is not too late to make it to 2.6, right?
> 
> You should add a line to
> http://wiki.qemu.org/Planning/2.6#Known_issues
> for things you think should be fixed for 2.6...

It would be nice for it to be in 2.6, however it's not actually
a 2.6 regression, it's been broken forever, but the difference
is that libvirt started using that bridge for q35 recently.

Dave

> thanks
> -- PMM
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

  reply	other threads:[~2016-04-04 16:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04 15:54 [Qemu-devel] [PATCH] Migration: Add i82801b11 migration data Dr. David Alan Gilbert (git)
2016-04-04 16:14 ` Marcel Apfelbaum
2016-04-04 16:37   ` Peter Maydell
2016-04-04 16:40     ` Dr. David Alan Gilbert [this message]
2016-04-04 16:43       ` Paolo Bonzini
2016-04-04 16:45     ` Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160404164039.GB6629@work-vm \
    --to=dgilbert@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).