From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an7YW-0001DS-NI for qemu-devel@nongnu.org; Mon, 04 Apr 2016 12:40:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1an7YS-0001xF-BW for qemu-devel@nongnu.org; Mon, 04 Apr 2016 12:40:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37255) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an7YS-0001x8-4j for qemu-devel@nongnu.org; Mon, 04 Apr 2016 12:40:44 -0400 Date: Mon, 4 Apr 2016 17:40:39 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20160404164039.GB6629@work-vm> References: <1459785281-6686-1-git-send-email-dgilbert@redhat.com> <570292CF.10305@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] Migration: Add i82801b11 migration data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Juan Quintela , "Michael S. Tsirkin" , QEMU Developers , Amit Shah , Marcel Apfelbaum , John Snow * Peter Maydell (peter.maydell@linaro.org) wrote: > On 4 April 2016 at 17:14, Marcel Apfelbaum wrote: > > On 04/04/2016 06:54 PM, Dr. David Alan Gilbert (git) wrote: > >> > >> From: "Dr. David Alan Gilbert" > >> > >> The i82801b11 bridge didn't have a vmsd and thus didn't send > >> any migration data, including that of its parent PCIBridge object. > >> The symptom being if the guest used any devices behind the bridge > >> the guest crashed (mostly with various interrupt related issues). > >> > >> Note: This will cause migration from old qemus that used this device to > >> explicitly fail during migration as opposed to the guest crashing. > > > If this patch was enough we got lucky :) > > Is not too late to make it to 2.6, right? > > You should add a line to > http://wiki.qemu.org/Planning/2.6#Known_issues > for things you think should be fixed for 2.6... It would be nice for it to be in 2.6, however it's not actually a 2.6 regression, it's been broken forever, but the difference is that libvirt started using that bridge for q35 recently. Dave > thanks > -- PMM -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK