From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anIlI-0006C5-AM for qemu-devel@nongnu.org; Tue, 05 Apr 2016 00:38:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anIlF-0002mW-41 for qemu-devel@nongnu.org; Tue, 05 Apr 2016 00:38:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anIlE-0002mS-Uy for qemu-devel@nongnu.org; Tue, 05 Apr 2016 00:38:41 -0400 Date: Tue, 5 Apr 2016 06:38:36 +0200 From: Kevin Wolf Message-ID: <20160405043836.GB4183@noname.redhat.com> References: <20160401080222.GC32728@redhat.com> <56FE2D42.5020607@redhat.com> <20160401081417.GD32728@redhat.com> <56FE3045.2030003@redhat.com> <20160401084456.GF32728@redhat.com> <1459502310.7011.37.camel@redhat.com> <20160401101733.GI32728@redhat.com> <1459508875.7011.62.camel@redhat.com> <20160401111139.GK32728@redhat.com> <20160401112027.GD19398@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160401112027.GD19398@redhat.com> Subject: Re: [Qemu-devel] Why is SeaBIOS used with -kernel? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Richard W.M. Jones" Cc: marc.mari.barcelo@gmail.com, Stefan Hajnoczi , qemu-devel@nongnu.org, Kevin O'Connor , Gerd Hoffmann , Paolo Bonzini Am 01.04.2016 um 13:20 hat Richard W.M. Jones geschrieben: > > My patch, plus the configuration and comments from your patch, > combined. Plus I tested it with libguestfs boot-analysis and it works > and is still fast. > > Integrating this so it happens automatically when the user adds > -kernel on x86 seems quite complicated. The only way I could do it > was by adding #ifdef defined(__x86_64__) etc to vl.c, which doesn't > seem very nice. The problem is the machine type code doesn't know > that you're using -kernel. I would actually find it rather surprising to get differernt BIOSes and therefore potentially different behaviour for -kernel and for booting from an image. Even if we made sure that Linux really never touches the parts that you disable in bios-fast.bin, remember that -kernel is not only for Linux, but for arbitrary kernels. Requiring an explicit -bios option like you do now seems to make most sense to me: The default behaves the same as a normal boot, but if you are one of the cases that do need that additional boot speed, you can do that and consciously sacrifice the features. Kevin