From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ankTK-0002Iy-66 for qemu-devel@nongnu.org; Wed, 06 Apr 2016 06:14:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ankTF-0001G7-5x for qemu-devel@nongnu.org; Wed, 06 Apr 2016 06:14:02 -0400 Received: from mail-bl2nam02on0065.outbound.protection.outlook.com ([104.47.38.65]:49097 helo=NAM02-BL2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ankTF-0001Ex-1w for qemu-devel@nongnu.org; Wed, 06 Apr 2016 06:13:57 -0400 Date: Wed, 6 Apr 2016 10:40:00 +0200 From: "Edgar E. Iglesias" Message-ID: <20160406084000.GL14668@toto> References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 0/3] slirp: deliver received TCP RSTs to the guest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: steven@steven676.net Cc: Jan Kiszka , qemu-devel@nongnu.org On Tue, Apr 05, 2016 at 05:13:58PM -0700, steven@steven676.net wrote: > QEMU's user-mode networking does not currently pass received TCP RSTs to > guests, meaning that applications in guests hang if the remote server > rejects their network connections. This is particularly noticeable when > IPv6 is enabled, the guest is configured to prefer IPv6 and the remote > server rejects IPv6 connections (segment-data.zqtk.net is one example), > but the bug appears to be longstanding and affects TCP over IPv4 as > well. > > There are three short patches in this series. The first fixes a crash > which would be exposed by the last patch in the series. The second, > which fixes delivery of an RST interrupting an already-established TCP > connection, was submitted by Edgar Iglesias in 2008 and appears to have > been missed then. The last patch fixes the case where the remote end > sends RST in reply to our SYN (rejects our incoming connection attempt). > > Lightly tested on a Linux host with Linux and Windows 7 guests. Thanks, the series looks good to me. Reviewed-by: Edgar E. Iglesias Cheers, Edgar > > Edgar E. Iglesias (1): > slirp: Propagate host TCP RST to the guest. > > Steven Luo (2): > slirp: don't crash when tcp_sockclosed() is called with a NULL tp > slirp: handle deferred ECONNREFUSED on non-blocking TCP sockets > > slirp/socket.c | 17 ++++++++++++++++- > slirp/tcp_input.c | 6 ++++++ > slirp/tcp_subr.c | 7 +++++-- > 3 files changed, 27 insertions(+), 3 deletions(-) > > -- > 2.1.4 >