From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anjFX-0004Uz-CS for qemu-devel@nongnu.org; Wed, 06 Apr 2016 04:55:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anjFU-0004tt-6F for qemu-devel@nongnu.org; Wed, 06 Apr 2016 04:55:43 -0400 Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:37340) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anjFT-0004tn-Mr for qemu-devel@nongnu.org; Wed, 06 Apr 2016 04:55:40 -0400 Received: by mail-wm0-x236.google.com with SMTP id n3so53272639wmn.0 for ; Wed, 06 Apr 2016 01:55:39 -0700 (PDT) Date: Wed, 6 Apr 2016 09:55:36 +0100 From: Stefan Hajnoczi Message-ID: <20160406085536.GA16003@stefanha-x1.localdomain> References: <1458292385-13802-1-git-send-email-b.reynal@virtualopensystems.com> <1458292385-13802-5-git-send-email-b.reynal@virtualopensystems.com> <20160331091222.GE32185@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SLDf9lqlvOQaIe6s" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [RFC v2 4/6] hw/misc: sdm virtio device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Baptiste Reynal Cc: Jani.Kokkonen@huawei.com, VirtualOpenSystems Technical Team , Claudio.Fontana@huawei.com, qemu list , Christian Pinto --SLDf9lqlvOQaIe6s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 05, 2016 at 02:54:56PM +0200, Baptiste Reynal wrote: > On Thu, Mar 31, 2016 at 11:12 AM, Stefan Hajnoczi wrote: > > On Fri, Mar 18, 2016 at 10:13:03AM +0100, Baptiste Reynal wrote: > >> This is the virtio implementation for an SDM device. > >> > >> Parameters are: > >> comm=[sdm_communication_id] specifies the communication channel > >> master=[true/false] - configure the SDM device as master or slave > >> num_slaves=[slave_number] - if master is true, specifies the number > >> of slaves > >> len-signals=[signals_number] - specifies the number of signals > >> signals[x]=[signal_id] - add a signal to the device, with the ID x > >> > >> Signed-off-by: Christian Pinto > >> Signed-off-by: Baptiste Reynal > >> --- > >> hw/virtio/Makefile.objs | 1 + > >> hw/virtio/virtio-sdm.c | 262 +++++++++++++++++++++++++++++++++++++++ > >> include/hw/virtio/virtio-sdm.h | 60 +++++++++ > >> linux-headers/linux/virtio_sdm.h | 52 ++++++++ > >> 4 files changed, 375 insertions(+) > >> create mode 100644 hw/virtio/virtio-sdm.c > >> create mode 100644 include/hw/virtio/virtio-sdm.h > >> create mode 100644 linux-headers/linux/virtio_sdm.h > > > > Have you posted a draft specification for this device to the VIRTIO > > Technical Committee? > > https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio > > > > Normally the spec should be accepted into VIRTIO before patches can be > > merged. > Thanks for the comment, I wasn't aware of such process. > I'll wait for some comments on the SDM in general, then I'll send a > draft spec to virtio. > Maybe this patchs should be dropped and reintroduced in a future patch series ? These things tend to take time so I suggest doing it in parallel: publish your QEMU patches while also trying to get your virtio spec change merged. --SLDf9lqlvOQaIe6s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXBM8IAAoJEJykq7OBq3PIiUsH/15LSeQapwh1m2sHAAGsOHPl xMBOH3EERej0vikSEUU4G7cdhd4nxaW5ZfTQUjGuSCOMfaM9o6baXy94e0GQ/fjW FveSuxEACO2kdkYuLh0Pq8mbMcPYpEwGIOfaEns0XVl6xUrdPBB8Ya7WW2HSStCU UGW/etzFuZwvT7yoG5KmMUc7vjSd/nVVWZzLPKdVnhEG86CQ1F9TR1HJQtLlMKrw MCskLMPD5x3rM8iJhGY2TtffYtCCtm+1pmFr6RM7lJlK9+gsjeDW99q4LZpGJBnR e4XHwbHw9qfVpQGIzwX5VwZE6gAtODEhSs3Wy4poHx8aEiwkDlH2/7oc6hKrhEc= =UDtZ -----END PGP SIGNATURE----- --SLDf9lqlvOQaIe6s--