From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54810) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ankvY-0002YC-CJ for qemu-devel@nongnu.org; Wed, 06 Apr 2016 06:43:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ankvX-0001rj-M6 for qemu-devel@nongnu.org; Wed, 06 Apr 2016 06:43:12 -0400 Date: Wed, 6 Apr 2016 12:43:04 +0200 From: Kevin Wolf Message-ID: <20160406104304.GD5098@noname.redhat.com> References: <1459934178-6142-1-git-send-email-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459934178-6142-1-git-send-email-berrange@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qemu-img: fix formatting of error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org Am 06.04.2016 um 11:16 hat Daniel P. Berrange geschrieben: > The error_reportf_err() will not automatically append a > ': ' before adding its suffix, so we must include that > in the message we pass it, otherwise we get a badly > formatted message lacking whitespace: > > qemu-img: Could not open 'driver=nbd,host=127.0.0.1,port=6666,tls-creds=tls0'Failed to connect socket: Connection refused > > Signed-off-by: Daniel P. Berrange Thanks, applied to the block branch. Kevin