qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Alex Bligh <alex@alex.org.uk>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Error when attempting to perform TLS NBD connection
Date: Wed, 6 Apr 2016 13:18:50 +0100	[thread overview]
Message-ID: <20160406121850.GK23124@redhat.com> (raw)
In-Reply-To: <5DD24DB4-7ADB-433B-82B2-09F2CB286965@alex.org.uk>

On Wed, Apr 06, 2016 at 12:40:44PM +0100, Alex Bligh wrote:
> Daniel,
> 
> On 6 Apr 2016, at 12:13, Daniel P. Berrange <berrange@redhat.com> wrote:
> 
> > So the problem turned out to be that the qemu-img program failed to
> > call qcrypto_init(), so gnutls had not had its one-time initialization
> > performed. This doesn't matter for gnutls 3.x but does for anything
> > older than that. I just copied you on a patch to fix this.
> 
> Thanks. I can confirm that fixes it at least up until the point
> it loads certificates. I will add Reviewed-By: and Tested-By: tags.
> 
> Can I suggest this might be suitable for qemu-stable as it's clearly
> a bug fix?

Only git master should be  affected by this, since the use of TLS by the
block layer is a new feature in 2.6 development.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

      reply	other threads:[~2016-04-06 12:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05 20:01 [Qemu-devel] Error when attempting to perform TLS NBD connection Alex Bligh
2016-04-06  9:09 ` Daniel P. Berrange
2016-04-06  9:11   ` Daniel P. Berrange
2016-04-06  9:22     ` Alex Bligh
2016-04-06  9:27       ` Daniel P. Berrange
2016-04-06  9:17   ` Alex Bligh
2016-04-06 11:13 ` Daniel P. Berrange
2016-04-06 11:40   ` Alex Bligh
2016-04-06 12:18     ` Daniel P. Berrange [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160406121850.GK23124@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex@alex.org.uk \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).