From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anmQF-0006Z1-3N for qemu-devel@nongnu.org; Wed, 06 Apr 2016 08:19:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anmQB-0001EF-B1 for qemu-devel@nongnu.org; Wed, 06 Apr 2016 08:18:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anmQB-0001EA-5U for qemu-devel@nongnu.org; Wed, 06 Apr 2016 08:18:55 -0400 Date: Wed, 6 Apr 2016 13:18:50 +0100 From: "Daniel P. Berrange" Message-ID: <20160406121850.GK23124@redhat.com> References: <20160406111335.GJ23124@redhat.com> <5DD24DB4-7ADB-433B-82B2-09F2CB286965@alex.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5DD24DB4-7ADB-433B-82B2-09F2CB286965@alex.org.uk> Subject: Re: [Qemu-devel] Error when attempting to perform TLS NBD connection Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh Cc: "qemu-devel@nongnu.org" On Wed, Apr 06, 2016 at 12:40:44PM +0100, Alex Bligh wrote: > Daniel, > > On 6 Apr 2016, at 12:13, Daniel P. Berrange wrote: > > > So the problem turned out to be that the qemu-img program failed to > > call qcrypto_init(), so gnutls had not had its one-time initialization > > performed. This doesn't matter for gnutls 3.x but does for anything > > older than that. I just copied you on a patch to fix this. > > Thanks. I can confirm that fixes it at least up until the point > it loads certificates. I will add Reviewed-By: and Tested-By: tags. > > Can I suggest this might be suitable for qemu-stable as it's clearly > a bug fix? Only git master should be affected by this, since the use of TLS by the block layer is a new feature in 2.6 development. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|