[Qemu-devel] 'make check' failure on Fedora 23

[Qemu-devel] 'make check' failure on Fedora 23

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 1429 bytes --]

Fedora 23 recently pushed acpica-tools.x86_64 20160318-1.fc23; with this
installed, 'make check-qtest' (part of 'make check') now fails with:

GTESTER check-qtest-x86_64
**
ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
(block_name)
GTester: last random seed: R02S920fc706036c189c6183c50ae002dbd1
**
ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
(block_name)
GTester: last random seed: R02Sccc109c5192857eddb99203160e3f750
**
ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
(block_name)
GTester: last random seed: R02S4c7289cb7d625a50855ca9a69e2ba8dc
**
ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
(block_name)
GTester: last random seed: R02Sf7cb7c41ed3718deced4d57cde200401
/home/eblake/qemu/tests/Makefile:638: recipe for target
'check-qtest-x86_64' failed

Reverting (# dnf downgrade --disablerepo=updates acpica-tools) to
acpica-tools.x86_64 20150619-2.fc23 lets the tests pass again.  I don't
know enough about the test or the tools to know if the problem is a
change in expected output (the qemu test is not tolerant enough, in
which case we should improve the test), or a regression in upstream
acpica-tools (in which case I should file a BZ), but this should
probably be addressed before 2.6.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] 'make check' failure on Fedora 23

[Wen Congyang]

On 04/06/2016 07:35 AM, Eric Blake wrote:
> Fedora 23 recently pushed acpica-tools.x86_64 20160318-1.fc23; with this
> installed, 'make check-qtest' (part of 'make check') now fails with:
> 
> GTESTER check-qtest-x86_64
> **
> ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
> (block_name)
> GTester: last random seed: R02S920fc706036c189c6183c50ae002dbd1
> **
> ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
> (block_name)
> GTester: last random seed: R02Sccc109c5192857eddb99203160e3f750
> **
> ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
> (block_name)
> GTester: last random seed: R02S4c7289cb7d625a50855ca9a69e2ba8dc
> **
> ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
> (block_name)
> GTester: last random seed: R02Sf7cb7c41ed3718deced4d57cde200401
> /home/eblake/qemu/tests/Makefile:638: recipe for target
> 'check-qtest-x86_64' failed
> 
> Reverting (# dnf downgrade --disablerepo=updates acpica-tools) to
> acpica-tools.x86_64 20150619-2.fc23 lets the tests pass again.  I don't
> know enough about the test or the tools to know if the problem is a
> change in expected output (the qemu test is not tolerant enough, in
> which case we should improve the test), or a regression in upstream
> acpica-tools (in which case I should file a BZ), but this should
> probably be addressed before 2.6.
> 

In the function load_asl(), we will use iasl to convert aml file to
asl source code file.

I copy the iasl file from /tmp/ to another directory, so I can use
old version and new version iasl to investigate.

Here is the different:
@@ -18,7 +18,7 @@
  *     Compiler ID      "BXPC"
  *     Compiler Version 0x00000001 (1)
  */
-DefinitionBlock ("t1.aml", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001)
+DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001)
 {
     Scope (\)
     {

The newest iasl does't output the aml filename: "tl.aml"

In the function normalize_asl(): we hope the output contains the aml filename...

Thanks
Wen Congyang

Re: [Qemu-devel] 'make check' failure on Fedora 23

[Wen Congyang]

On 04/06/2016 07:35 AM, Eric Blake wrote:
> Fedora 23 recently pushed acpica-tools.x86_64 20160318-1.fc23; with this
> installed, 'make check-qtest' (part of 'make check') now fails with:
> 
> GTESTER check-qtest-x86_64
> **
> ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
> (block_name)
> GTester: last random seed: R02S920fc706036c189c6183c50ae002dbd1
> **
> ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
> (block_name)
> GTester: last random seed: R02Sccc109c5192857eddb99203160e3f750
> **
> ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
> (block_name)
> GTester: last random seed: R02S4c7289cb7d625a50855ca9a69e2ba8dc
> **
> ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
> (block_name)
> GTester: last random seed: R02Sf7cb7c41ed3718deced4d57cde200401
> /home/eblake/qemu/tests/Makefile:638: recipe for target
> 'check-qtest-x86_64' failed
> 
> Reverting (# dnf downgrade --disablerepo=updates acpica-tools) to
> acpica-tools.x86_64 20150619-2.fc23 lets the tests pass again.  I don't
> know enough about the test or the tools to know if the problem is a
> change in expected output (the qemu test is not tolerant enough, in
> which case we should improve the test), or a regression in upstream
> acpica-tools (in which case I should file a BZ), but this should
> probably be addressed before 2.6.

After this commit, iasl's output is changed:
https://github.com/acpica/acpica/commit/1ecbb3d551255dab943f3bbe7e9da0145d154bba

Thanks
Wen Congyang

> 

Re: [Qemu-devel] 'make check' failure on Fedora 23

[Marcel Apfelbaum]

On 04/06/2016 02:35 AM, Eric Blake wrote:
> Fedora 23 recently pushed acpica-tools.x86_64 20160318-1.fc23; with this
> installed, 'make check-qtest' (part of 'make check') now fails with:
>
> GTESTER check-qtest-x86_64
> **
> ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
> (block_name)
> GTester: last random seed: R02S920fc706036c189c6183c50ae002dbd1
> **
> ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
> (block_name)
> GTester: last random seed: R02Sccc109c5192857eddb99203160e3f750
> **
> ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
> (block_name)
> GTester: last random seed: R02S4c7289cb7d625a50855ca9a69e2ba8dc
> **
> ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
> (block_name)
> GTester: last random seed: R02Sf7cb7c41ed3718deced4d57cde200401
> /home/eblake/qemu/tests/Makefile:638: recipe for target
> 'check-qtest-x86_64' failed
>
> Reverting (# dnf downgrade --disablerepo=updates acpica-tools) to
> acpica-tools.x86_64 20150619-2.fc23 lets the tests pass again.  I don't
> know enough about the test or the tools to know if the problem is a
> change in expected output (the qemu test is not tolerant enough, in
> which case we should improve the test), or a regression in upstream
> acpica-tools (in which case I should file a BZ), but this should
> probably be addressed before 2.6.
>

I've already posted a fix for this: [PATCH] tests/bios-tables-test: fix assert
http://patchwork.ozlabs.org/patch/605931/

Thanks,
Marcel

Re: [Qemu-devel] 'make check' failure on Fedora 23

[Michael S. Tsirkin]

On Tue, Apr 05, 2016 at 05:35:38PM -0600, Eric Blake wrote:
> Fedora 23 recently pushed acpica-tools.x86_64 20160318-1.fc23; with this
> installed, 'make check-qtest' (part of 'make check') now fails with:
> 
> GTESTER check-qtest-x86_64
> **
> ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
> (block_name)
> GTester: last random seed: R02S920fc706036c189c6183c50ae002dbd1
> **
> ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
> (block_name)
> GTester: last random seed: R02Sccc109c5192857eddb99203160e3f750
> **
> ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
> (block_name)
> GTester: last random seed: R02S4c7289cb7d625a50855ca9a69e2ba8dc
> **
> ERROR:tests/bios-tables-test.c:455:normalize_asl: assertion failed:
> (block_name)
> GTester: last random seed: R02Sf7cb7c41ed3718deced4d57cde200401
> /home/eblake/qemu/tests/Makefile:638: recipe for target
> 'check-qtest-x86_64' failed
> 
> Reverting (# dnf downgrade --disablerepo=updates acpica-tools) to
> acpica-tools.x86_64 20150619-2.fc23 lets the tests pass again.  I don't
> know enough about the test or the tools to know if the problem is a
> change in expected output (the qemu test is not tolerant enough, in
> which case we should improve the test), or a regression in upstream
> acpica-tools (in which case I should file a BZ), but this should
> probably be addressed before 2.6.
> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 



My tree has a fix which I will send upstream shortly.