From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55766)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ndevos@redhat.com>) id 1anox8-0005w8-Hg
	for qemu-devel@nongnu.org; Wed, 06 Apr 2016 11:01:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ndevos@redhat.com>) id 1anox2-0006Xh-Vr
	for qemu-devel@nongnu.org; Wed, 06 Apr 2016 11:01:06 -0400
Date: Wed, 6 Apr 2016 17:00:49 +0200
From: Niels de Vos <ndevos@redhat.com>
Message-ID: <20160406150049.GN17260@ndevos-x240.usersys.redhat.com>
References: <cover.1459913103.git.jcody@redhat.com>
	<a88fcaed20c098f116116ec6d38e5e7cc5326c4e.1459913103.git.jcody@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a88fcaed20c098f116116ec6d38e5e7cc5326c4e.1459913103.git.jcody@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.6 1/2] block/gluster: return correct
	error value
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org

On Tue, Apr 05, 2016 at 11:29:51PM -0400, Jeff Cody wrote:
> Upon error, gluster will call the aio callback function with a
> ret value of -1, with errno set to the proper error value.  If
> we set the acb->ret value to the return value in the callback,
> that results in every error being EPERM (i.e. 1).  Instead, set
> it to the proper error result.
> 
> Signed-off-by: Jeff Cody <jcody@redhat.com>

Looks good to me.

Reviewed-by: Niels de Vos <ndevos@redhat.com>

> ---
>  block/gluster.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/gluster.c b/block/gluster.c
> index 7bface2..30a827e 100644
> --- a/block/gluster.c
> +++ b/block/gluster.c
> @@ -245,7 +245,7 @@ static void gluster_finish_aiocb(struct glfs_fd *fd, ssize_t ret, void *arg)
>      if (!ret || ret == acb->size) {
>          acb->ret = 0; /* Success */
>      } else if (ret < 0) {
> -        acb->ret = ret; /* Read/Write failed */
> +        acb->ret = -errno; /* Read/Write failed */
>      } else {
>          acb->ret = -EIO; /* Partial read/write - fail it */
>      }
> -- 
> 1.9.3
>