From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1annQm-00026d-7K for qemu-devel@nongnu.org; Wed, 06 Apr 2016 09:23:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1annQh-0008Mn-7c for qemu-devel@nongnu.org; Wed, 06 Apr 2016 09:23:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54583) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1annQh-0008Mf-1q for qemu-devel@nongnu.org; Wed, 06 Apr 2016 09:23:31 -0400 Date: Wed, 6 Apr 2016 16:23:27 +0300 From: "Michael S. Tsirkin" Message-ID: <20160406161945-mutt-send-email-mst@redhat.com> References: <1456162651-22181-1-git-send-email-leonid.bloch@ravellosystems.com> <1456162651-22181-14-git-send-email-leonid.bloch@ravellosystems.com> <56DE9BF1.3050709@redhat.com> <7BD4DE03-17BA-4638-A751-13DDC5F9A79F@daynix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7BD4DE03-17BA-4638-A751-13DDC5F9A79F@daynix.com> Subject: Re: [Qemu-devel] [PATCH v2 13/13] net: Introduce e1000e device emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dmitry Fleytman Cc: Leonid Bloch , Jason Wang , Leonid Bloch , qemu-devel@nongnu.org, Shmulik Ladkani On Wed, Apr 06, 2016 at 11:22:24AM +0300, Dmitry Fleytman wrote: > + MemoryRegion flash; > > > Looks there's no real implementation for flash. So is this really needed > (e.g did WHQL or other test check for this?). > > > From our experience some drivers may verify that device exposes all memory > regions as required by HW specification, so we added this dummy memory region > to be on the safe side. But then, why use an io region? Also, pls add some comments that explains this. -- MSt