From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40841)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1annlO-00035j-9I
	for qemu-devel@nongnu.org; Wed, 06 Apr 2016 09:44:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1annlI-0005O2-Me
	for qemu-devel@nongnu.org; Wed, 06 Apr 2016 09:44:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34699)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1annlI-0005Ny-HX
	for qemu-devel@nongnu.org; Wed, 06 Apr 2016 09:44:48 -0400
Date: Wed, 6 Apr 2016 16:44:45 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20160406164434-mutt-send-email-mst@redhat.com>
References: <1456162651-22181-1-git-send-email-leonid.bloch@ravellosystems.com>
	<1456162651-22181-14-git-send-email-leonid.bloch@ravellosystems.com>
	<56DE9BF1.3050709@redhat.com>
	<7BD4DE03-17BA-4638-A751-13DDC5F9A79F@daynix.com>
	<20160406161945-mutt-send-email-mst@redhat.com>
	<C961FB24-891A-4743-B0DC-63EA7DAA8C8D@daynix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <C961FB24-891A-4743-B0DC-63EA7DAA8C8D@daynix.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 13/13] net: Introduce e1000e device
 emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dmitry Fleytman <dmitry@daynix.com>
Cc: Leonid Bloch <leonid.bloch@ravellosystems.com>, Jason Wang <jasowang@redhat.com>, Leonid Bloch <leonid@daynix.com>, qemu-devel@nongnu.org, Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>

On Wed, Apr 06, 2016 at 04:42:57PM +0300, Dmitry Fleytman wrote:
>=20
> > On 6 Apr 2016, at 16:23 PM, Michael S. Tsirkin <mst@redhat.com> wrote=
:
> >=20
> > On Wed, Apr 06, 2016 at 11:22:24AM +0300, Dmitry Fleytman wrote:
> >>        +    MemoryRegion flash;
> >>=20
> >>=20
> >>    Looks there's no real implementation for flash. So is this really=
 needed
> >>    (e.g did WHQL or other test check for this?).
> >>=20
> >>=20
> >> From our experience some drivers may verify that device exposes all =
memory
> >> regions as required by HW specification, so we added this dummy memo=
ry region
> >> to be on the safe side.
> >=20
> > But then, why use an io region?
>=20
> Do you mean we should use memory_region_init() instead of memory_region=
_init_io() for registration?

Exactly.

> > Also, pls add some comments that explains this.
>=20
> I=E2=80=99ll add. Thanks.
>=20
> >=20
> > --=20
> > MSt