From: Samuel Thibault <samuel.thibault@gnu.org>
To: Steven Luo <steven@steven676.net>
Cc: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] slirp: deliver received TCP RSTs to the guest
Date: Thu, 7 Apr 2016 02:17:10 +0200 [thread overview]
Message-ID: <20160407001710.GK2920@var.home> (raw)
In-Reply-To: <20160407000050.GA21369@steven676.net>
Hello,
Steven Luo, on Wed 06 Apr 2016 17:00:50 -0700, wrote:
> That said, sorecvoob() also calls soread(), so I'd guess we need to
> deal with the possibility that soread() frees the socket in that case
> as well?
Indeed, then sorecvoob() needs to return that information, so
slirp_pollfds_poll can avoid doing anything else with this socket.
> I could take care of this when I resend this patch series, if you
> prefer.
If you like, please do :)
> I think this should be "might have been removed"? tcp_sockclosed()
> doesn't seem to call tcp_close() in every case, so we can get -1 from
> soread() without the socket being freed.
Right.
Samuel
prev parent reply other threads:[~2016-04-07 0:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 0:13 [Qemu-devel] [PATCH 0/3] slirp: deliver received TCP RSTs to the guest steven
2016-04-06 0:14 ` [Qemu-devel] [PATCH 1/3] slirp: don't crash when tcp_sockclosed() is called with a NULL tp steven
2016-04-06 0:14 ` [Qemu-devel] [PATCH 2/3] slirp: Propagate host TCP RST to the guest steven
2016-04-06 8:28 ` Paolo Bonzini
2016-04-06 8:36 ` Edgar E. Iglesias
2016-04-06 14:59 ` Steven Luo
2016-04-06 0:14 ` [Qemu-devel] [PATCH 3/3] slirp: handle deferred ECONNREFUSED on non-blocking TCP sockets steven
2016-04-06 7:26 ` [Qemu-devel] [PATCH 0/3] slirp: deliver received TCP RSTs to the guest Thomas Huth
2016-04-06 8:40 ` Edgar E. Iglesias
2016-04-06 12:57 ` Samuel Thibault
2016-04-07 0:00 ` Steven Luo
2016-04-07 0:17 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407001710.GK2920@var.home \
--to=samuel.thibault@gnu.org \
--cc=edgar.iglesias@xilinx.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=steven@steven676.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).