From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52463)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from
	<SRS0=2Ojw=QC=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1anxdN-0008NN-CC
	for qemu-devel@nongnu.org; Wed, 06 Apr 2016 20:17:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from
	<SRS0=2Ojw=QC=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1anxdK-0004cy-5H
	for qemu-devel@nongnu.org; Wed, 06 Apr 2016 20:17:17 -0400
Received: from domu-toccata.ens-lyon.fr ([140.77.166.138]:50219
	helo=sonata.ens-lyon.org) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from
	<SRS0=2Ojw=QC=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1anxdJ-0004cj-Um
	for qemu-devel@nongnu.org; Wed, 06 Apr 2016 20:17:14 -0400
Date: Thu, 7 Apr 2016 02:17:10 +0200
From: Samuel Thibault <samuel.thibault@gnu.org>
Message-ID: <20160407001710.GK2920@var.home>
References: <1c0611a61621b2069df831b48b937fa49cc264bd.1459896208.git.steven@steven676.net>
	<cover.1459896208.git.steven@steven676.net>
	<20160406125743.GC28379@var.bordeaux.inria.fr>
	<20160407000050.GA21369@steven676.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160407000050.GA21369@steven676.net>
Subject: Re: [Qemu-devel] [PATCH 0/3] slirp: deliver received TCP RSTs to
 the guest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Steven Luo <steven@steven676.net>
Cc: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org

Hello,

Steven Luo, on Wed 06 Apr 2016 17:00:50 -0700, wrote:
> That said, sorecvoob() also calls soread(), so I'd guess we need to
> deal with the possibility that soread() frees the socket in that case
> as well?

Indeed, then sorecvoob() needs to return that information, so
slirp_pollfds_poll can avoid doing anything else with this socket.

> I could take care of this when I resend this patch series, if you
> prefer.

If you like, please do :)

> I think this should be "might have been removed"?  tcp_sockclosed()
> doesn't seem to call tcp_close() in every case, so we can get -1 from
> soread() without the socket being freed.

Right.

Samuel