From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58167) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ao0vh-0000ON-Fb for qemu-devel@nongnu.org; Wed, 06 Apr 2016 23:48:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ao0vg-0000EE-Jf for qemu-devel@nongnu.org; Wed, 06 Apr 2016 23:48:25 -0400 Date: Thu, 7 Apr 2016 06:48:15 +0300 From: "Michael S. Tsirkin" Message-ID: <20160407064806-mutt-send-email-mst@redhat.com> References: <1459673515-14354-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] xen: piix reuse pci generic class init function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: John Snow , qemu-devel@nongnu.org, qemu-block@nongnu.org On Wed, Apr 06, 2016 at 04:56:12PM -0700, Stefano Stabellini wrote: > On Sun, 3 Apr 2016, Michael S. Tsirkin wrote: > > piix3_ide_xen_class_init is identical to piix3_ide_class_init > > except it's buggy as it does not set exit and does not disable > > hotplug properly. > > > > Switch to the generic one. > > > > Reviewed-by: Stefano Stabellini > > Signed-off-by: Michael S. Tsirkin > > Hey John, > > are you going to take the patch or do you want me to handle it? > > Cheers, > > Stefano it's in my tree already. > > > hw/ide/piix.c | 14 +------------- > > 1 file changed, 1 insertion(+), 13 deletions(-) > > > > diff --git a/hw/ide/piix.c b/hw/ide/piix.c > > index df46147..0a4cbcb 100644 > > --- a/hw/ide/piix.c > > +++ b/hw/ide/piix.c > > @@ -258,22 +258,10 @@ static const TypeInfo piix3_ide_info = { > > .class_init = piix3_ide_class_init, > > }; > > > > -static void piix3_ide_xen_class_init(ObjectClass *klass, void *data) > > -{ > > - DeviceClass *dc = DEVICE_CLASS(klass); > > - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); > > - > > - k->realize = pci_piix_ide_realize; > > - k->vendor_id = PCI_VENDOR_ID_INTEL; > > - k->device_id = PCI_DEVICE_ID_INTEL_82371SB_1; > > - k->class_id = PCI_CLASS_STORAGE_IDE; > > - set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); > > -} > > - > > static const TypeInfo piix3_ide_xen_info = { > > .name = "piix3-ide-xen", > > .parent = TYPE_PCI_IDE, > > - .class_init = piix3_ide_xen_class_init, > > + .class_init = piix3_ide_class_init, > > }; > > > > static void piix4_ide_class_init(ObjectClass *klass, void *data) > > -- > > MST > >