From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Alberto Garcia <berto@igalia.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 for-2.7 1/8] block: Drop useless bdrv_new() call
Date: Thu, 7 Apr 2016 14:09:22 +0200 [thread overview]
Message-ID: <20160407120922.GC4509@noname.redhat.com> (raw)
In-Reply-To: <1459965434-21531-2-git-send-email-mreitz@redhat.com>
Am 06.04.2016 um 19:57 hat Max Reitz geschrieben:
> bdrv_append_temp_snapshot() uses bdrv_new() to create an empty BDS
> before invoking bdrv_open() on that BDS. This is probably a relict from
> when it used to do some modifications on that empty BDS, but now that is
> unnecessary, so we can just set bs_snapshot to NULL and let bdrv_open()
> do the rest.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2016-04-07 12:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 17:57 [Qemu-devel] [PATCH v2 for-2.7 0/8] blockdev: (Nearly) free clean-up work Max Reitz
2016-04-06 17:57 ` [Qemu-devel] [PATCH v2 for-2.7 1/8] block: Drop useless bdrv_new() call Max Reitz
2016-04-07 12:03 ` Alberto Garcia
2016-04-07 12:09 ` Kevin Wolf [this message]
2016-04-06 17:57 ` [Qemu-devel] [PATCH v2 for-2.7 2/8] block: Let bdrv_open_inherit() return the snapshot Max Reitz
2016-04-07 11:29 ` Kevin Wolf
2016-04-08 15:49 ` Max Reitz
2016-04-08 16:26 ` Kevin Wolf
2016-04-06 17:57 ` [Qemu-devel] [PATCH v2 for-2.7 3/8] tests: Drop BDS from test-throttle.c Max Reitz
2016-04-07 12:11 ` Kevin Wolf
2016-04-06 17:57 ` [Qemu-devel] [PATCH v2 for-2.7 4/8] block: Drop blk_new_with_bs() Max Reitz
2016-04-07 12:14 ` Kevin Wolf
2016-04-06 17:57 ` [Qemu-devel] [PATCH v2 for-2.7 5/8] block: Drop bdrv_new_root() Max Reitz
2016-04-07 12:17 ` Kevin Wolf
2016-04-06 17:57 ` [Qemu-devel] [PATCH v2 for-2.7 6/8] block: Make bdrv_open() return a BDS Max Reitz
2016-04-07 12:39 ` Kevin Wolf
2016-04-06 17:57 ` [Qemu-devel] [PATCH v2 for-2.7 7/8] block: Assert !bs->refcnt in bdrv_close() Max Reitz
2016-04-07 12:40 ` Kevin Wolf
2016-04-06 17:57 ` [Qemu-devel] [PATCH v2 for-2.7 8/8] block: Drop bdrv_parent_cb_...() from bdrv_close() Max Reitz
2016-04-07 12:40 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407120922.GC4509@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).