From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ao9EZ-0002EA-SY for qemu-devel@nongnu.org; Thu, 07 Apr 2016 08:40:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ao9EU-0006St-5U for qemu-devel@nongnu.org; Thu, 07 Apr 2016 08:40:27 -0400 Date: Thu, 7 Apr 2016 14:40:11 +0200 From: Kevin Wolf Message-ID: <20160407124011.GH4509@noname.redhat.com> References: <1459965434-21531-1-git-send-email-mreitz@redhat.com> <1459965434-21531-8-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459965434-21531-8-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 for-2.7 7/8] block: Assert !bs->refcnt in bdrv_close() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Alberto Garcia , qemu-devel@nongnu.org, qemu-block@nongnu.org Am 06.04.2016 um 19:57 hat Max Reitz geschrieben: > The only caller of bdrv_close() left is bdrv_delete(). We may as well > assert that, in a way (there are some things in bdrv_close() that make > more sense under that assumption, such as the call to > bdrv_release_all_dirty_bitmaps() which in turn assumes that no frozen > bitmaps are attached to the BDS). > > In addition, being called only in bdrv_delete() means that we can drop > bdrv_close()'s forward declaration at the top of block.c. > > Signed-off-by: Max Reitz > Reviewed-by: Alberto Garcia Reviewed-by: Kevin Wolf