From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoEwj-000619-Fz for qemu-devel@nongnu.org; Thu, 07 Apr 2016 14:46:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoEum-0008HJ-5F for qemu-devel@nongnu.org; Thu, 07 Apr 2016 14:44:25 -0400 Received: from lists.gnu.org ([2001:4830:134:3::11]:43276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoEum-0008HE-26 for qemu-devel@nongnu.org; Thu, 07 Apr 2016 14:44:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoEuf-000619-73 for qemu-devel@nongnu.org; Thu, 07 Apr 2016 14:44:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoEuN-0008BG-Hk for qemu-devel@nongnu.org; Thu, 07 Apr 2016 14:44:04 -0400 Received: from lists.gnu.org ([2001:4830:134:3::11]:49166) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoEuN-0008BA-EL for qemu-devel@nongnu.org; Thu, 07 Apr 2016 14:43:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoEBW-0002gq-Uk for qemu-devel@nongnu.org; Thu, 07 Apr 2016 13:57:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoDe1-0001XW-L3 for qemu-devel@nongnu.org; Thu, 07 Apr 2016 13:23:04 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:40562) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoDe1-0001XJ-HN for qemu-devel@nongnu.org; Thu, 07 Apr 2016 13:23:01 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5E0C820ABF for ; Thu, 7 Apr 2016 13:23:01 -0400 (EDT) Date: Thu, 7 Apr 2016 13:23:00 -0400 From: "Emilio G. Cota" Message-ID: <20160407172300.GA24410@flamenco> References: <1460049562-23517-1-git-send-email-cota@braap.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460049562-23517-1-git-send-email-cota@braap.org> Subject: Re: [Qemu-devel] [PATCH] tb: consistently use uint32_t for tb->flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Peter Crosthwaite , Richard Henderson , Eduardo Habkost , Michael Walle , Aurelien Jarno , Leon Alrae , Anthony Green , Jia Liu , Alexander Graf , Blue Swirl , Mark Cave-Ayland , Bastian Koppelmann , Guan Xuetao , Max Filippov , "Edgar E. Iglesias" , "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Laurent Desnogues , MTTCG Devel On Thu, Apr 07, 2016 at 13:19:22 -0400, Emilio G. Cota wrote: > We are inconsistent with the type of tb->flags: usage varies loosely > between int and uint64_t. Settle to uint32_t everywhere, which is > superior to both: at least one target (aarch64) uses the most significant > bit in the u32, and uint64_t is wasteful. > > Compile-tested for all targets. > > Suggested-by: Laurent Desnogues > Suggested-by: Richard Henderson > Signed-off-by: Emilio G. Cota Context: https://lists.gnu.org/archive/html/qemu-devel/2016-04/msg01110.html Thanks, Emilio