From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45363)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aoTsV-0000d0-VS
	for qemu-devel@nongnu.org; Fri, 08 Apr 2016 06:43:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aoTsU-0002ug-S3
	for qemu-devel@nongnu.org; Fri, 08 Apr 2016 06:43:03 -0400
Date: Fri, 8 Apr 2016 18:42:54 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160408104254.GC5807@ad.usersys.redhat.com>
References: <1459264128-12761-1-git-send-email-kwolf@redhat.com>
	<1459264128-12761-49-git-send-email-kwolf@redhat.com>
	<57067179.7060401@redhat.com>
	<20160408011848.GA5807@ad.usersys.redhat.com>
	<20160408102114.GA4700@noname.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160408102114.GA4700@noname.redhat.com>
Subject: Re: [Qemu-devel] [PULL 48/48] iotests: Test qemu-img convert -S 0
 behavior
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com

On Fri, 04/08 12:21, Kevin Wolf wrote:
> Am 08.04.2016 um 03:18 hat Fam Zheng geschrieben:
> > On Thu, 04/07 16:40, Paolo Bonzini wrote:
> > > 
> > > 
> > > On 29/03/2016 17:08, Kevin Wolf wrote:
> > > > From: Max Reitz <mreitz@redhat.com>
> > > > 
> > > > Passing -S 0 to qemu-img convert should result in all source data being
> > > > copied to the output, even if that source data is known to be 0. The
> > > > output image should therefore have exactly the same size on disk as an
> > > > image which we explicitly filled with data.
> > > > 
> > > > Signed-off-by: Max Reitz <mreitz@redhat.com>
> > > > Reviewed-by: Fam Zheng <famz@redhat.com>
> > > > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > > 
> > > This fails with XFS and raw format, which preallocates an extra cluster
> > > at the end of the file created with qemu-io (so that the on-disk size is
> > > 2056 512-byte blocks).
> > 
> > Maybe squash in http://patchwork.ozlabs.org/patch/603047/ ?
> 
> It's too late to squash it in, but yes, that should be the fix for it.
> 

Yes, didn't know it's already merged.

Fam