From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.6] vpc: fix return value check for blk_pwrite
Date: Fri, 8 Apr 2016 13:55:07 +0200 [thread overview]
Message-ID: <20160408115507.GF4700@noname.redhat.com> (raw)
In-Reply-To: <1460040754-108375-1-git-send-email-pbonzini@redhat.com>
Am 07.04.2016 um 16:52 hat Paolo Bonzini geschrieben:
> bdrv_pwrite_sync used to return zero or negative error, while blk_pwrite returns
> the number of written bytes when successful. This caused VPC image creation
> to fail spectacularly: it wrote the first 512 bytes, and then exited immediately
> because of the non-zero answer from blk_pwrite. But the truly spectacular part
> is that it returns a positive value (the 512 that blk_pwrite returned) causing
> everyone to believe that it succeeded.
>
> This fixes qemu-iotests with vpc format.
>
> Fixes: b8f45cdf7827e39f9a1e6cc446f5972cc6144237
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2016-04-08 11:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 14:52 [Qemu-devel] [PATCH for-2.6] vpc: fix return value check for blk_pwrite Paolo Bonzini
2016-04-08 11:55 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160408115507.GF4700@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).