Re: [Qemu-devel] [PATCH 1/2] seccomp: Whitelist cacheflush since 2.2.0 not 2.2.3

[James Hogan <james.hogan@imgtec.com>]

[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]

On Fri, Apr 08, 2016 at 01:49:44PM +0100, Peter Maydell wrote:
> On 8 April 2016 at 13:39, Andrew Jones <drjones@redhat.com> wrote:
> > In that message I was referring to arm/aarch64 (the only arch at the
> > time that cared about cacheflush). 2.2.0 was the first version arm got
> > any cacheflush support (same version as x86 an mips), but it was
> > completely wrong until 2.2.1. Additional problems were then fixed for
> > 2.2.3. x86 doesn't use cacheflush and mips didn't have any problems
> > (I guess), so they've been fine since 2.2.0.
> >
> > As long as the configure script still requires a libseccomp_minver of
> > 2.2.3 for arm/aarch64, then it doesn't matter if the HAVE_CACHEFLUSH
> > minimum version in qemu-seccomp.c is relaxed for the other
> > architectures that work.
> 
> OK. Could we have a comment, maybe something like:
>  /* For some architectures (notably ARM) cacheflush is not
>   * supported until libseccomp 2.2.3, but configure enforces that
>   * we are using a more recent version on those hosts, so it is OK
>   * for this check to be less strict.
>   */
> 
> ? (or feel free to reword if you have a better idea).

Sure, I'll do a v2.

Cheers
James

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]