From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jitendra Kolhe <jitendra.kolhe@hpe.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com,
crosthwaite.peter@gmail.com, rth@twiddle.net, eblake@redhat.com,
lcapitulino@redhat.com, stefanha@redhat.com, armbru@redhat.com,
quintela@redhat.com, den@openvz.org, JBottomley@Odin.com,
borntraeger@de.ibm.com, amit.shah@redhat.com,
dgilbert@redhat.com, ehabkost@redhat.com,
mohan_parthasarathy@hpe.com, simhan@hpe.com
Subject: Re: [Qemu-devel] [PATCH v2] migration: skip sending ram pages released by virtio-balloon driver.
Date: Wed, 13 Apr 2016 14:10:32 +0300 [thread overview]
Message-ID: <20160413111032.GA22137@redhat.com> (raw)
In-Reply-To: <570E257F.3060205@hpe.com>
On Wed, Apr 13, 2016 at 04:24:55PM +0530, Jitendra Kolhe wrote:
> Can we extend support for post-copy in a different patch set?
If the optimization does not *help* on some paths,
that's fine. The issue is with adding extra code
special-casing protocols:
+ if (migrate_postcopy_ram()) {
+ balloon_bitmap_disable_state = BALLOON_BITMAP_DISABLE_PERMANENT;
+ }
Generally when one sees that patchset breaks XYZ...
the easy solution is "check for XYZ
and disable the optimization". But do this enough times
and the codebase becomes impossible to reason about.
why did migration become slower? oh it enabled
optimization A and that conflicts with optimization B ...
> and use
> current patch set to support other remaining protocols?
Even disregarding postcopy, I think there were
comments that need to be addressed.
--
MST
next prev parent reply other threads:[~2016-04-13 11:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 4:16 [Qemu-devel] [PATCH v2] migration: skip sending ram pages released by virtio-balloon driver Jitendra Kolhe
2016-03-28 6:59 ` Michael S. Tsirkin
2016-03-29 10:05 ` Paolo Bonzini
2016-03-29 10:47 ` Jitendra Kolhe
2016-03-29 10:48 ` Paolo Bonzini
2016-04-01 11:19 ` Jitendra Kolhe
2016-03-28 10:36 ` Denis V. Lunev
2016-03-29 11:34 ` Jitendra Kolhe
2016-03-28 14:11 ` Eric Blake
2016-03-29 12:13 ` Jitendra Kolhe
2016-03-29 12:28 ` Michael S. Tsirkin
2016-04-01 11:08 ` Jitendra Kolhe
2016-04-10 16:59 ` Michael S. Tsirkin
2016-04-13 10:54 ` Jitendra Kolhe
2016-04-13 11:10 ` Michael S. Tsirkin [this message]
2016-04-13 11:15 ` Dr. David Alan Gilbert
2016-04-13 11:36 ` Michael S. Tsirkin
2016-04-29 10:31 ` Jitendra Kolhe
2016-03-31 16:39 ` Dr. David Alan Gilbert
2016-04-05 10:04 ` Jitendra Kolhe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413111032.GA22137@redhat.com \
--to=mst@redhat.com \
--cc=JBottomley@Odin.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=crosthwaite.peter@gmail.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jitendra.kolhe@hpe.com \
--cc=lcapitulino@redhat.com \
--cc=mohan_parthasarathy@hpe.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=simhan@hpe.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).