From: Kevin Wolf <kwolf@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
stefanha@redhat.com, grantwwu@gmail.com, sbaugh@catern.com
Subject: Re: [Qemu-devel] [PATCH for-2.6 1/7] block/vpc: fix VPC 'qemu-img create' regression
Date: Wed, 13 Apr 2016 18:48:19 +0200 [thread overview]
Message-ID: <20160413164819.GB4624@noname.redhat.com> (raw)
In-Reply-To: <20160413154013.GB7187@localhost.localdomain>
Am 13.04.2016 um 17:40 hat Jeff Cody geschrieben:
> On Tue, Mar 22, 2016 at 11:33:38PM -0400, Jeff Cody wrote:
> > Commit 'b8f45cdf7827e39f9a1e6cc446f5972cc6144237' switched VPC
> > over to using blk_pwrite() instead of bdrv_pwrite_sync(). The
> > return value of bdrv_pwrite_sync() was always 0 for success, and
> > create_dynamic_disk() in one instance checked for a non-zero return
> > value to indicate error. However, blk_pwrite() may return positive
> > values for success.
> >
> > This fails silently as well, since vpc_create() did not set errp
> > in this failuer case. Set errp in all instances in vpc_create().
> >
> > Signed-off-by: Jeff Cody <jcody@redhat.com>
>
> Ping on this series - ideally the whole series for 2.6, but this patch
> in particular is needed for 2.6 to prevent a regression from 2.5 (QEMU
> can no longer create VPC/VHD images without this patch).
The regression was already fixed in commit 40a99aac. With some changes
in the commit message, the rest of this patch is still useful.
Kevin
next prev parent reply other threads:[~2016-04-13 16:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 3:33 [Qemu-devel] [PATCH for-2.6 0/7] block: VHD format fixes Jeff Cody
2016-03-23 3:33 ` [Qemu-devel] [PATCH for-2.6 1/7] block/vpc: fix VPC 'qemu-img create' regression Jeff Cody
2016-03-23 16:56 ` Stefan Hajnoczi
2016-04-13 15:40 ` Jeff Cody
2016-04-13 16:48 ` Kevin Wolf [this message]
2016-03-23 3:33 ` [Qemu-devel] [PATCH for-2.6 2/7] vpc: use current_size field for XenServer VHD images Jeff Cody
2016-03-23 3:33 ` [Qemu-devel] [PATCH for-2.6 3/7] block/vpc: use current_size field for XenConverter " Jeff Cody
2016-03-23 3:33 ` [Qemu-devel] [PATCH for-2.6 4/7] block/vpc: Use the correct max sector count for " Jeff Cody
2016-03-23 3:33 ` [Qemu-devel] [PATCH for-2.6 5/7] block/vpc: make checks on max table size a bit more lax Jeff Cody
2016-03-23 3:33 ` [Qemu-devel] [PATCH for-2.6 6/7] block/vpc: set errp in vpc_open Jeff Cody
2016-03-23 3:33 ` [Qemu-devel] [PATCH for-2.6 7/7] block/vpc: update comments to be compliant w/coding guidelines Jeff Cody
2016-04-13 16:55 ` Kevin Wolf
2016-03-23 18:06 ` [Qemu-devel] [PATCH for-2.6 0/7] block: VHD format fixes Stefan Hajnoczi
2016-04-13 16:57 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413164819.GB4624@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=grantwwu@gmail.com \
--cc=jcody@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sbaugh@catern.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).