From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49798)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1aqNxs-0000A3-Po
	for qemu-devel@nongnu.org; Wed, 13 Apr 2016 12:48:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1aqNxr-00077B-WC
	for qemu-devel@nongnu.org; Wed, 13 Apr 2016 12:48:28 -0400
Date: Wed, 13 Apr 2016 18:48:19 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20160413164819.GB4624@noname.redhat.com>
References: <cover.1458702790.git.jcody@redhat.com>
	<0cf3d19bbc32776d12b46cd471f82c20ea9ce182.1458702790.git.jcody@redhat.com>
	<20160413154013.GB7187@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160413154013.GB7187@localhost.localdomain>
Subject: Re: [Qemu-devel] [PATCH for-2.6 1/7] block/vpc: fix VPC 'qemu-img
 create' regression
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, stefanha@redhat.com, grantwwu@gmail.com, sbaugh@catern.com

Am 13.04.2016 um 17:40 hat Jeff Cody geschrieben:
> On Tue, Mar 22, 2016 at 11:33:38PM -0400, Jeff Cody wrote:
> > Commit 'b8f45cdf7827e39f9a1e6cc446f5972cc6144237' switched VPC
> > over to using blk_pwrite() instead of bdrv_pwrite_sync().  The
> > return value of bdrv_pwrite_sync() was always 0 for success, and
> > create_dynamic_disk() in one instance checked for a non-zero return
> > value to indicate error.  However, blk_pwrite() may return positive
> > values for success.
> > 
> > This fails silently as well, since vpc_create() did not set errp
> > in this failuer case.  Set errp in all instances in vpc_create().
> > 
> > Signed-off-by: Jeff Cody <jcody@redhat.com>
> 
> Ping on this series - ideally the whole series for 2.6, but this patch
> in particular is needed for 2.6 to prevent a regression from 2.5 (QEMU
> can no longer create VPC/VHD images without this patch).

The regression was already fixed in commit 40a99aac. With some changes
in the commit message, the rest of this patch is still useful.

Kevin