From: Kevin Wolf <kwolf@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
stefanha@redhat.com, grantwwu@gmail.com, sbaugh@catern.com
Subject: Re: [Qemu-devel] [PATCH for-2.6 7/7] block/vpc: update comments to be compliant w/coding guidelines
Date: Wed, 13 Apr 2016 18:55:05 +0200 [thread overview]
Message-ID: <20160413165505.GC4624@noname.redhat.com> (raw)
In-Reply-To: <7a8456be516dae2be739c358fb6b114cddd3efbd.1458702790.git.jcody@redhat.com>
Am 23.03.2016 um 04:33 hat Jeff Cody geschrieben:
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
> block/vpc.c | 70 ++++++++++++++++++++++++++++++-------------------------------
> 1 file changed, 35 insertions(+), 35 deletions(-)
>
> diff --git a/block/vpc.c b/block/vpc.c
> index 5dd9950..0b48cf4 100644
> --- a/block/vpc.c
> +++ b/block/vpc.c
> @@ -36,7 +36,7 @@
>
> #define HEADER_SIZE 512
>
> -//#define CACHE
> +/* #define CACHE */
I'll revert this one while applying, C99 style is much more convenient
when you want to enable debugging and we're doing the same in other
places.
The rest of them is good.
Kevin
next prev parent reply other threads:[~2016-04-13 16:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 3:33 [Qemu-devel] [PATCH for-2.6 0/7] block: VHD format fixes Jeff Cody
2016-03-23 3:33 ` [Qemu-devel] [PATCH for-2.6 1/7] block/vpc: fix VPC 'qemu-img create' regression Jeff Cody
2016-03-23 16:56 ` Stefan Hajnoczi
2016-04-13 15:40 ` Jeff Cody
2016-04-13 16:48 ` Kevin Wolf
2016-03-23 3:33 ` [Qemu-devel] [PATCH for-2.6 2/7] vpc: use current_size field for XenServer VHD images Jeff Cody
2016-03-23 3:33 ` [Qemu-devel] [PATCH for-2.6 3/7] block/vpc: use current_size field for XenConverter " Jeff Cody
2016-03-23 3:33 ` [Qemu-devel] [PATCH for-2.6 4/7] block/vpc: Use the correct max sector count for " Jeff Cody
2016-03-23 3:33 ` [Qemu-devel] [PATCH for-2.6 5/7] block/vpc: make checks on max table size a bit more lax Jeff Cody
2016-03-23 3:33 ` [Qemu-devel] [PATCH for-2.6 6/7] block/vpc: set errp in vpc_open Jeff Cody
2016-03-23 3:33 ` [Qemu-devel] [PATCH for-2.6 7/7] block/vpc: update comments to be compliant w/coding guidelines Jeff Cody
2016-04-13 16:55 ` Kevin Wolf [this message]
2016-03-23 18:06 ` [Qemu-devel] [PATCH for-2.6 0/7] block: VHD format fixes Stefan Hajnoczi
2016-04-13 16:57 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413165505.GC4624@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=grantwwu@gmail.com \
--cc=jcody@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sbaugh@catern.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).