From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44117) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqM1t-00070K-Ja for qemu-devel@nongnu.org; Wed, 13 Apr 2016 10:44:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqM1o-0003mK-H8 for qemu-devel@nongnu.org; Wed, 13 Apr 2016 10:44:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqM1o-0003mA-Bd for qemu-devel@nongnu.org; Wed, 13 Apr 2016 10:44:24 -0400 Date: Wed, 13 Apr 2016 17:44:20 +0300 From: "Michael S. Tsirkin" Message-ID: <20160413173957-mutt-send-email-mst@redhat.com> References: <1460102035-15972-1-git-send-email-mst@redhat.com> <87twjcvz7o.fsf@dusky.pond.sub.org> <20160409200141-mutt-send-email-mst@redhat.com> <8760voo18x.fsf@dusky.pond.sub.org> <20160411142509-mutt-send-email-mst@redhat.com> <8760vlq3yg.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8760vlq3yg.fsf@dusky.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH v3] fw_cfg: RFQDN rules, documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Paolo Bonzini , "Gabriel L . Somlo" , Laszlo Ersek , qemu-devel@nongnu.org, Gerd Hoffmann On Wed, Apr 13, 2016 at 10:59:35AM +0200, Markus Armbruster wrote: > If we can protect them without > complicating or breaking stuff, sure, why not. But not at all costs. The stuff we break is precisely the stuff our warnings say might break at any time. So since you believe users might be relied on not to ignore warnings, it should be ok ... As for complicating things - about 5 lines of code are spent on the unsupported/root/ hack. It *is* a hack but contained enough not to worry me too much ... -- MST