From: Igor Mammedov <imammedo@redhat.com>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] hostmem-file: plug a small leak
Date: Thu, 14 Apr 2016 13:34:20 +0200 [thread overview]
Message-ID: <20160414133420.6c49cc27@nial.brq.redhat.com> (raw)
In-Reply-To: <1460566660-19241-1-git-send-email-marcandre.lureau@redhat.com>
On Wed, 13 Apr 2016 18:57:40 +0200
marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> backends/hostmem-file.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c
> index b17a1f1..5c4b808 100644
> --- a/backends/hostmem-file.c
> +++ b/backends/hostmem-file.c
> @@ -121,11 +121,19 @@ file_backend_instance_init(Object *o)
> set_mem_path, NULL);
> }
>
> +static void file_backend_instance_finalize(Object *o)
> +{
> + HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
> +
> + g_free(fb->mem_path);
> +}
> +
> static const TypeInfo file_backend_info = {
> .name = TYPE_MEMORY_BACKEND_FILE,
> .parent = TYPE_MEMORY_BACKEND,
> .class_init = file_backend_class_init,
> .instance_init = file_backend_instance_init,
> + .instance_finalize = file_backend_instance_finalize,
> .instance_size = sizeof(HostMemoryBackendFile),
> };
>
next prev parent reply other threads:[~2016-04-14 11:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 16:57 [Qemu-devel] [PATCH] hostmem-file: plug a small leak marcandre.lureau
2016-04-14 11:34 ` Igor Mammedov [this message]
2016-04-14 13:24 ` Paolo Bonzini
2016-04-14 15:44 ` Igor Mammedov
2016-04-14 17:26 ` Paolo Bonzini
2016-04-15 6:56 ` Markus Armbruster
2016-04-15 13:49 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414133420.6c49cc27@nial.brq.redhat.com \
--to=imammedo@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).