From: Kevin Wolf <kwolf@redhat.com>
To: Sascha Silbe <silbe@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [for-2.6] Re: [PATCH] qmp-commands.hx: document minimum speed for block jobs
Date: Fri, 15 Apr 2016 17:35:20 +0200 [thread overview]
Message-ID: <20160415153520.GI4341@noname.redhat.com> (raw)
In-Reply-To: <878u0gih1h.fsf@oc4731375738.ibm.com>
Am 14.04.2016 um 13:08 hat Sascha Silbe geschrieben:
> Dear developers,
>
> Sascha Silbe <silbe@linux.vnet.ibm.com> writes:
>
> > The current rate limit implementation for block jobs is ineffective
> > below a certain minimum rate. It will permit writes at least once per
> > time slice. The resulting minimum write speed (assuming source and
> > sink are fast enough in the first place) is high enough that it may
> > surprise some users, so document it. Mention that this will be fixed
> > in the future, otherwise some users might misguidedly rely on it or
> > clamp their configuration settings to the documented value.
>
> Forgot to mention: This is 2.6 material as it documents a known
> shortcoming that will hopefully be fixed in 2.7.
Isn't the JSON schema (qapi/block-core.json) considered the
authoritative source for interface specifications these days? I think if
we want to document the shortcomings for the time being, we should
document it in both places.
Kevin
next prev parent reply other threads:[~2016-04-15 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 20:59 [Qemu-devel] [PATCH] qmp-commands.hx: document minimum speed for block jobs Sascha Silbe
2016-04-14 11:08 ` [Qemu-devel] [for-2.6] " Sascha Silbe
2016-04-15 15:35 ` Kevin Wolf [this message]
2016-04-19 19:05 ` Sascha Silbe
2016-04-19 19:23 ` Eric Blake
2016-04-19 19:37 ` Sascha Silbe
2016-04-19 19:03 ` [Qemu-devel] [PATCH v2] QMP: " Sascha Silbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160415153520.GI4341@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=silbe@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).