From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arzan-00082Y-M7 for qemu-devel@nongnu.org; Sun, 17 Apr 2016 23:11:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1arzai-0006wz-Jl for qemu-devel@nongnu.org; Sun, 17 Apr 2016 23:11:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arzai-0006wv-EJ for qemu-devel@nongnu.org; Sun, 17 Apr 2016 23:11:12 -0400 Date: Mon, 18 Apr 2016 11:11:05 +0800 From: Peter Xu Message-ID: <20160418031105.GA8975@pxdev.xzpeter.org> References: <1460691099-3024-1-git-send-email-peterx@redhat.com> <1460691099-3024-3-git-send-email-peterx@redhat.com> <5712F541.60703@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5712F541.60703@web.de> Subject: Re: [Qemu-devel] [PATCH v3 02/13] intel_iommu: set IR bit for ECAP register List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org, imammedo@redhat.com, rth@twiddle.net, ehabkost@redhat.com, jasowang@redhat.com, marcel@redhat.com, mst@redhat.com, pbonzini@redhat.com, rkrcmar@redhat.com, alex.williamson@redhat.com, wexu@redhat.com On Sat, Apr 16, 2016 at 07:30:25PM -0700, Jan Kiszka wrote: > On 2016-04-14 20:31, Peter Xu wrote: > > Enable IR in IOMMU Extended Capability register. > > > > Signed-off-by: Peter Xu > > --- > > hw/i386/intel_iommu.c | 7 +++++++ > > hw/i386/intel_iommu_internal.h | 2 ++ > > 2 files changed, 9 insertions(+) > > > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > > index 4b0558e..17668d6 100644 > > --- a/hw/i386/intel_iommu.c > > +++ b/hw/i386/intel_iommu.c > > @@ -24,6 +24,7 @@ > > #include "exec/address-spaces.h" > > #include "intel_iommu_internal.h" > > #include "hw/pci/pci.h" > > +#include "hw/boards.h" > > > > /*#define DEBUG_INTEL_IOMMU*/ > > #ifdef DEBUG_INTEL_IOMMU > > @@ -1941,6 +1942,8 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState *s, PCIBus *bus, int devfn) > > */ > > static void vtd_init(IntelIOMMUState *s) > > { > > + MachineState *ms = MACHINE(qdev_get_machine()); > > + > > memset(s->csr, 0, DMAR_REG_SIZE); > > memset(s->wmask, 0, DMAR_REG_SIZE); > > memset(s->w1cmask, 0, DMAR_REG_SIZE); > > @@ -1961,6 +1964,10 @@ static void vtd_init(IntelIOMMUState *s) > > VTD_CAP_SAGAW | VTD_CAP_MAMV | VTD_CAP_PSI | VTD_CAP_SLLPS; > > s->ecap = VTD_ECAP_QI | VTD_ECAP_IRO; > > > > + if (ms->iommu_intr) { > > This cannot work, the field doesn't exit yet. > > Please test bisectability after reordering patches. Oh god, I missed one patch. There should be 14 patches, while it seems that I generated only 13. :( Sorry for the misunderstanding. Will repost as v4. -- peterx