qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Cole Robinson <crobinso@redhat.com>,
	libvirt-list@redhat.com, qemu-devel <qemu-devel@nongnu.org>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	Peter Krempa <pkrempa@redhat.com>,
	Amit Shah <amit.shah@redhat.com>,
	mik@miknet.net, jjaburek@redhat.com, hkario@redhat.com,
	sgrubb@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
	Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-devel] RFC: virtio-rng and /dev/urandom
Date: Mon, 18 Apr 2016 10:28:42 +0100	[thread overview]
Message-ID: <20160418092842.GB19600@redhat.com> (raw)
In-Reply-To: <B5ADC920-3A49-4CBD-88B0-352D6C208863@zytor.com>

On Fri, Apr 15, 2016 at 08:56:59AM -0700, H. Peter Anvin wrote:
> On April 15, 2016 3:41:34 AM PDT, Cole Robinson <crobinso@redhat.com> wrote:
> >Libvirt currently rejects using host /dev/urandom as an input source
> >for a
> >virtio-rng device. The only accepted sources are /dev/random and
> >/dev/hwrng.
> >This is the result of discussions on qemu-devel around when the feature
> >was
> >first added (2013). Examples:
> >
> >http://lists.gnu.org/archive/html/qemu-devel/2012-09/msg02387.html
> >https://lists.gnu.org/archive/html/qemu-devel/2013-03/threads.html#00023
> >
> >libvirt's rejection of /dev/urandom has generated some complaints from
> >users:
> >
> >https://bugzilla.redhat.com/show_bug.cgi?id=1074464
> >* cited: http://www.2uo.de/myths-about-urandom/
> >http://www.redhat.com/archives/libvir-list/2016-March/msg01062.html
> >http://www.redhat.com/archives/libvir-list/2016-April/msg00186.html
> >
> >I think it's worth having another discussion about this, at least with
> >a
> >recent argument in one place so we can put it to bed. I'm CCing a bunch
> >of
> >people. I think the questions are:
> >
> >1) is the original recommendation to never use virtio-rng+/dev/urandom
> >correct?
> >
> >2) regardless of #1, should we continue to reject that config in
> >libvirt?
> >
> >Thanks,
> >Cole
> 
> Using /dev/urandom for virtio-rng, *except* perhaps for a small seed,
> it a complete waste of cycles.  There is absolutely no reason to have
> one prng feed another.

Regardless of the performance aspect, the key question we need the
answer to is whether it *cryptographically safe* to use /dev/urandom
on the host to feed virtio-rng. The original discussion said it was
/unsafe/ to use /dev/urandom, hence why we do not allow it.  If the
only downside is wasted performance, then it is reasonable to allow
the user to use /dev/urandom if they so wish.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

  parent reply	other threads:[~2016-04-18  9:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-15 10:41 [Qemu-devel] RFC: virtio-rng and /dev/urandom Cole Robinson
2016-04-15 11:46 ` Richard W.M. Jones
2016-04-15 11:54   ` [Qemu-devel] [libvirt] " Richard W.M. Jones
2016-04-20 22:48   ` [Qemu-devel] " Steve Grubb
2016-04-15 15:47 ` Eric Blake
2016-04-15 16:10   ` Hubert Kario
2016-04-16  0:46     ` H. Peter Anvin
2016-04-16  0:51     ` H. Peter Anvin
2016-04-16  8:31       ` Paolo Bonzini
2016-04-18  0:20         ` H. Peter Anvin
2016-04-18  0:27         ` H. Peter Anvin
2016-04-18 11:21           ` Hubert Kario
2016-04-18 11:00       ` Hubert Kario
2016-04-19 11:30   ` [Qemu-devel] [libvirt] " Yaniv Kaul
2016-04-15 15:56 ` [Qemu-devel] " H. Peter Anvin
2016-04-15 16:06   ` Hubert Kario
2016-04-18  9:28   ` Daniel P. Berrange [this message]
2016-04-18  9:46     ` H. Peter Anvin
2016-04-18 11:07       ` Hubert Kario
2016-04-18 11:26         ` Daniel P. Berrange
2016-04-18 21:45           ` H. Peter Anvin
2016-04-20 22:21 ` Cole Robinson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160418092842.GB19600@redhat.com \
    --to=berrange@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=crobinso@redhat.com \
    --cc=eblake@redhat.com \
    --cc=hkario@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jjaburek@redhat.com \
    --cc=libvirt-list@redhat.com \
    --cc=mik@miknet.net \
    --cc=pbonzini@redhat.com \
    --cc=pkrempa@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    --cc=sgrubb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).