From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Liang Li <liang.z.li@intel.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com, amit.shah@redhat.com
Subject: Re: [Qemu-devel] [PATCH] migration: remove useless code
Date: Mon, 18 Apr 2016 10:45:53 +0100 [thread overview]
Message-ID: <20160418094553.GC2222@work-vm> (raw)
In-Reply-To: <1460971172-2240-1-git-send-email-liang.z.li@intel.com>
* Liang Li (liang.z.li@intel.com) wrote:
> page_buffer is set twice repeatedly, remove the previous set.
>
> Signed-off-by: Liang Li <liang.z.li@intel.com>
> ---
> migration/ram.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 3f05738..31d40f4 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -2322,7 +2322,6 @@ static int ram_load_postcopy(QEMUFile *f)
> ret = -EINVAL;
> break;
> }
> - page_buffer = host;
> /*
> * Postcopy requires that we place whole host pages atomically.
> * To make it atomic, the data is read into a temporary page
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> --
> 1.9.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2016-04-18 9:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 9:19 [Qemu-devel] [PATCH] migration: remove useless code Liang Li
2016-04-18 9:45 ` Dr. David Alan Gilbert [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-01-27 6:11 Liang Li
2016-01-27 6:59 ` Fam Zheng
2016-01-27 9:08 ` Dr. David Alan Gilbert
2016-02-04 10:05 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160418094553.GC2222@work-vm \
--to=dgilbert@redhat.com \
--cc=amit.shah@redhat.com \
--cc=liang.z.li@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).