From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1as5kn-0000yH-73 for qemu-devel@nongnu.org; Mon, 18 Apr 2016 05:46:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1as5kk-0003f0-I9 for qemu-devel@nongnu.org; Mon, 18 Apr 2016 05:46:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55406) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1as5kk-0003ev-De for qemu-devel@nongnu.org; Mon, 18 Apr 2016 05:45:58 -0400 Date: Mon, 18 Apr 2016 10:45:53 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20160418094553.GC2222@work-vm> References: <1460971172-2240-1-git-send-email-liang.z.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460971172-2240-1-git-send-email-liang.z.li@intel.com> Subject: Re: [Qemu-devel] [PATCH] migration: remove useless code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liang Li Cc: qemu-devel@nongnu.org, quintela@redhat.com, amit.shah@redhat.com * Liang Li (liang.z.li@intel.com) wrote: > page_buffer is set twice repeatedly, remove the previous set. > > Signed-off-by: Liang Li > --- > migration/ram.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/migration/ram.c b/migration/ram.c > index 3f05738..31d40f4 100644 > --- a/migration/ram.c > +++ b/migration/ram.c > @@ -2322,7 +2322,6 @@ static int ram_load_postcopy(QEMUFile *f) > ret = -EINVAL; > break; > } > - page_buffer = host; > /* > * Postcopy requires that we place whole host pages atomically. > * To make it atomic, the data is read into a temporary page Reviewed-by: Dr. David Alan Gilbert > -- > 1.9.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK