From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1asXt7-0004MU-FL for qemu-devel@nongnu.org; Tue, 19 Apr 2016 11:48:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1asXt2-0006r9-HK for qemu-devel@nongnu.org; Tue, 19 Apr 2016 11:48:29 -0400 Date: Tue, 19 Apr 2016 11:48:17 -0400 From: Jeff Cody Message-ID: <20160419154817.GD7187@localhost.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH for-2.6 v3 0/3] Bug fixes for gluster List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org On Tue, Apr 19, 2016 at 10:16:18AM -0400, Jeff Cody wrote: > Change from v2: > > Look at the error return from the aio callback from > fsync, as well. (thanks Kevin) > > > Bug fixes for gluster; third patch is to prevent > a potential data loss when trying to recover from > a recoverable error (such as ENOSPC). > > The final patch closes the gluster fd and sets the > protocol drv to NULL on fsync failure in gluster; > we have no way of knowing what gluster versions > support retaining fysnc cache on error, so until > we do the safest thing to do is invalidate the > drive. > > Jeff Cody (3): > block/gluster: return correct error value > block/gluster: code movement of qemu_gluster_close() > block/gluster: prevent data loss after i/o error > > block/gluster.c | 77 +++++++++++++++++++++++++++++++++++++++++++++++---------- > configure | 8 ++++++ > 2 files changed, 72 insertions(+), 13 deletions(-) > > -- > 1.9.3 > Thanks, Applied to my block branch: git://github.com/codyprime/qemu-kvm-jtc.git block -Jeff