From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1asYZv-0005Z4-Ta for qemu-devel@nongnu.org; Tue, 19 Apr 2016 12:32:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1asYZs-0004VA-Ds for qemu-devel@nongnu.org; Tue, 19 Apr 2016 12:32:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40860) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1asYZs-0004Tz-9O for qemu-devel@nongnu.org; Tue, 19 Apr 2016 12:32:40 -0400 Date: Tue, 19 Apr 2016 19:32:33 +0300 From: "Michael S. Tsirkin" Message-ID: <20160419192925-mutt-send-email-mst@redhat.com> References: <1461075643-3668-1-git-send-email-liang.z.li@intel.com> <1461075643-3668-4-git-send-email-liang.z.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461075643-3668-4-git-send-email-liang.z.li@intel.com> Subject: Re: [Qemu-devel] [PATCH QEMU 3/5] virtio-balloon: Add a new feature to balloon device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liang Li Cc: quintela@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, armbru@redhat.com, peter.maydell@linaro.org, rth@twiddle.net, ehabkost@redhat.com, james.hogan@imgtec.com, aurelien@aurel32.net, leon.alrae@imgtec.com, agraf@suse.de, borntraeger@de.ibm.com, cornelia.huck@de.ibm.com, qemu-devel@nongnu.org, kvm@vger.kernel.org On Tue, Apr 19, 2016 at 10:20:41PM +0800, Liang Li wrote: > + if (s->req_status == REQ_INIT) { > + s->free_page_bmap = bitmap; > + if (elem == NULL || !elem->in_num) { > + elem = virtqueue_pop(s->fvq, sizeof(VirtQueueElement)); > + if (!elem) { > + return FREE_PAGE_ERROR; > + } > + s->free_page_vq_elem = elem; > + } > + s->free_page_req.param = drop_cache_ctl; Dropping cache should probably be a separate request - seems independently useful. -- MST