From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1asdil-0007qZ-Bt for qemu-devel@nongnu.org; Tue, 19 Apr 2016 18:02:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1asdig-0001kl-Ij for qemu-devel@nongnu.org; Tue, 19 Apr 2016 18:02:11 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:34066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1asdig-0001kh-Cs for qemu-devel@nongnu.org; Tue, 19 Apr 2016 18:02:06 -0400 Received: from localhost by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 19 Apr 2016 16:02:05 -0600 Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id DCB573E40060 for ; Tue, 19 Apr 2016 16:02:02 -0600 (MDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u3JM22NU16711758 for ; Tue, 19 Apr 2016 15:02:02 -0700 Received: from d03av01.boulder.ibm.com (localhost [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u3JM22hh019693 for ; Tue, 19 Apr 2016 16:02:02 -0600 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <1461051553-14720-1-git-send-email-hongyang.yang@easystack.cn> References: <1461051553-14720-1-git-send-email-hongyang.yang@easystack.cn> Message-ID: <20160419220157.14340.80493@loki> Date: Tue, 19 Apr 2016 17:01:57 -0500 Subject: Re: [Qemu-devel] [PATCH] qemu-ga: do not run qga test when guest agent disabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yang Hongyang , qemu-devel@nongnu.org Cc: Gerd Hoffmann , "Michael S. Tsirkin" , Paolo Bonzini , peter.maydell@linaro.org Quoting Yang Hongyang (2016-04-19 02:39:13) > When configure with --disable-guest-agent, make check will fail with: > ERROR:tests/test-qga.c:74:fixture_setup: assertion failed (error =3D=3D N= ULL): > Failed to execute child process "/home/xx/qemu/qemu-ga" (No such file or > directory) (g-exec-error-quark, 8) > make: *** [check-tests/test-qga] Error 1 > = > This check was commented out by bab47d9a75a. I think that was by > mistake, because the commit message of that commit didn't mention > this change. > = > Signed-off-by: Yang Hongyang > Cc: Gerd Hoffmann > Cc: Michael S. Tsirkin > Cc: Michael Roth > Cc: Paolo Bonzini Thanks, applied to qga tree: https://github.com/mdroth/qemu/commits/qga As much as I'd like to get this fixed for 2.6, the net effect, thanks to the inadvertant commenting out of qga test case in bab47d9a75a, is that the qemu-ga unit test currently gets skipped during make check. Given RC3 is going to be tagged soon, and afaik is the last RC, I'm not sure I would consider this enough of a blocker to send a last-minute pull. Peter: if you think there's still a window to get this in let me know and I'll send the pull immediately. But for now I'll queue this for 2.7 and for stable. > --- > tests/Makefile | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > = > diff --git a/tests/Makefile b/tests/Makefile > index 9de9598..9194f18 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -83,7 +83,9 @@ check-unit-y +=3D tests/test-crypto-cipher$(EXESUF) > check-unit-y +=3D tests/test-crypto-secret$(EXESUF) > check-unit-$(CONFIG_GNUTLS) +=3D tests/test-crypto-tlscredsx509$(EXESUF) > check-unit-$(CONFIG_GNUTLS) +=3D tests/test-crypto-tlssession$(EXESUF) > -#check-unit-$(CONFIG_LINUX) +=3D tests/test-qga$(EXESUF) > +ifneq (,$(findstring qemu-ga,$(TOOLS))) > +check-unit-$(CONFIG_LINUX) +=3D tests/test-qga$(EXESUF) > +endif > check-unit-y +=3D tests/test-timed-average$(EXESUF) > check-unit-y +=3D tests/test-io-task$(EXESUF) > check-unit-y +=3D tests/test-io-channel-socket$(EXESUF) > -- = > 1.8.3.1 >=20